Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Side by Side Diff: chrome/browser/resources/settings/device_page/power.html

Issue 2853113004: chromeos: Add settings to control power management prefs. (Closed)
Patch Set: fix async call Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 2
3 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_indicat or.html">
3 <link rel="import" href="chrome://resources/html/cr.html"> 4 <link rel="import" href="chrome://resources/html/cr.html">
4 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> 5 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
5 <link rel="import" href="chrome://resources/html/md_select_css.html"> 6 <link rel="import" href="chrome://resources/html/md_select_css.html">
6 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> 7 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
7 <link rel="import" href="../route.html"> 8 <link rel="import" href="../route.html">
8 <link rel="import" href="../settings_shared_css.html"> 9 <link rel="import" href="../settings_shared_css.html">
9 10
10 <dom-module id="settings-power"> 11 <dom-module id="settings-power">
11 <template> 12 <template>
12 <style include="settings-shared md-select"></style> 13 <style include="settings-shared md-select"></style>
(...skipping 15 matching lines...) Expand all
28 [[item.description]] 29 [[item.description]]
29 </option> 30 </option>
30 </template> 31 </template>
31 </select> 32 </select>
32 <span class="md-select-underline"></span> 33 <span class="md-select-underline"></span>
33 </div> 34 </div>
34 <div hidden$="[[showPowerSourceDropdown_]]"> 35 <div hidden$="[[showPowerSourceDropdown_]]">
35 [[powerSourceName_]] 36 [[powerSourceName_]]
36 </div> 37 </div>
37 </div> 38 </div>
39
40 <div class="settings-box">
41 <div class="start">$i18n{powerIdleLabel}</div>
hcarmona 2017/06/19 22:18:11 Consider giving this element and ID and using aria
Daniel Erat 2017/06/19 23:11:21 i've tried this (see next patch set), but i always
42 <template is="dom-if" if="[[idleControlled_]]" restamp>
43 <cr-policy-indicator id="idleControlledIndicator"
hcarmona 2017/06/19 22:18:11 Please set the icon-aria-label property for a11y.
Daniel Erat 2017/06/19 23:11:21 Done.
44 indicator-type="devicePolicy">
45 </cr-policy-indicator>
46 </template>
47 <div class="md-select-wrapper">
48 <select id="idleSelect" class="md-select"
49 on-change="onIdleSelectChange_" aria-label="$i18n{powerIdleLabel}"
50 disabled="[[idleControlled_]]">
51 <template is="dom-repeat" items="[[idleOptions_]]">
52 <option value="[[item.value]]">[[item.name]]</option>
53 </template>
54 </select>
55 <span class="md-select-underline"></span>
56 </div>
57 </div>
58
59 <div id="lidClosedRow" class="settings-box continuation"
hcarmona 2017/06/19 22:18:11 Same a11y suggestions for the children of this ele
Daniel Erat 2017/06/19 23:11:21 Done.
60 hidden$="[[!hasLid_]]">
michaelpg 2017/06/19 22:38:06 nit: 4-space indent
Daniel Erat 2017/06/19 23:11:21 Done.
61 <div class="start">$i18n{powerLidClosedLabel}</div>
62 <template is="dom-if" if="[[lidClosedControlled_]]" restamp>
63 <cr-policy-indicator id="lidClosedControlledIndicator"
64 indicator-type="devicePolicy">
65 </cr-policy-indicator>
66 </template>
67 <div class="md-select-wrapper">
68 <select id="lidClosedSelect" class="md-select"
69 on-change="onLidClosedSelectChange_"
70 aria-label="$i18n{powerLidClosedLabel}"
71 disabled="[[lidClosedControlled_]]">
72 <template is="dom-repeat" items="[[lidClosedOptions_]]">
73 <option value="[[item.value]]">[[item.name]]</option>
74 </template>
75 </select>
76 <span class="md-select-underline"></span>
77 </div>
78 </div>
38 </template> 79 </template>
39 <script src="power.js"></script> 80 <script src="power.js"></script>
40 </dom-module> 81 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698