Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <link rel="import" href="chrome://resources/html/polymer.html"> | 1 <link rel="import" href="chrome://resources/html/polymer.html"> |
| 2 | 2 |
| 3 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_indicat or.html"> | |
| 3 <link rel="import" href="chrome://resources/html/cr.html"> | 4 <link rel="import" href="chrome://resources/html/cr.html"> |
| 4 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> | 5 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> |
| 5 <link rel="import" href="chrome://resources/html/md_select_css.html"> | 6 <link rel="import" href="chrome://resources/html/md_select_css.html"> |
| 6 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> | 7 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> |
| 7 <link rel="import" href="../route.html"> | 8 <link rel="import" href="../route.html"> |
| 8 <link rel="import" href="../settings_shared_css.html"> | 9 <link rel="import" href="../settings_shared_css.html"> |
| 9 | 10 |
| 10 <dom-module id="settings-power"> | 11 <dom-module id="settings-power"> |
| 11 <template> | 12 <template> |
| 12 <style include="settings-shared md-select"></style> | 13 <style include="settings-shared md-select"></style> |
| (...skipping 15 matching lines...) Expand all Loading... | |
| 28 [[item.description]] | 29 [[item.description]] |
| 29 </option> | 30 </option> |
| 30 </template> | 31 </template> |
| 31 </select> | 32 </select> |
| 32 <span class="md-select-underline"></span> | 33 <span class="md-select-underline"></span> |
| 33 </div> | 34 </div> |
| 34 <div hidden$="[[showPowerSourceDropdown_]]"> | 35 <div hidden$="[[showPowerSourceDropdown_]]"> |
| 35 [[powerSourceName_]] | 36 [[powerSourceName_]] |
| 36 </div> | 37 </div> |
| 37 </div> | 38 </div> |
| 39 | |
| 40 <div class="settings-box"> | |
| 41 <div class="start">$i18n{powerIdleLabel}</div> | |
| 42 <template is="dom-if" if="[[idleManaged_]]" restamp> | |
| 43 <cr-policy-indicator id="idleManagedIndicator" | |
|
michaelpg
2017/06/16 01:35:00
Ask hcarmona@ what the correct aria use is here:
Daniel Erat
2017/06/16 02:34:24
i noticed this pattern too (and think i had this i
| |
| 44 indicator-type="devicePolicy"> | |
| 45 </cr-policy-indicator> | |
| 46 </template> | |
| 47 <div class="md-select-wrapper"> | |
| 48 <select id="idleSelect" class="md-select" | |
| 49 on-change="onIdleSelectChange_" aria-label="$i18n{powerIdleLabel}" | |
| 50 disabled="[[idleManaged_]]"> | |
| 51 <template is="dom-repeat" items="[[idleOptions_]]"> | |
| 52 <option value="[[item.value]]">[[item.name]]</option> | |
| 53 </template> | |
| 54 </select> | |
| 55 <span class="md-select-underline"></span> | |
| 56 </div> | |
| 57 </div> | |
| 58 | |
| 59 <div class="settings-box continuation" hidden$="[[!hasLid_]]"> | |
| 60 <div class="start">$i18n{powerLidClosedLabel}</div> | |
| 61 <template is="dom-if" if="[[lidClosedManaged_]]" restamp> | |
| 62 <cr-policy-indicator id="lidClosedManagedIndicator" | |
|
michaelpg
2017/06/16 01:35:00
(ditto)
Daniel Erat
2017/06/16 02:34:24
Acknowledged.
| |
| 63 indicator-type="devicePolicy"> | |
| 64 </cr-policy-indicator> | |
| 65 </template> | |
| 66 <div class="md-select-wrapper"> | |
| 67 <select id="lidClosedSelect" class="md-select" | |
| 68 on-change="onLidClosedSelectChange_" | |
| 69 aria-label="$i18n{powerLidClosedLabel}" | |
| 70 disabled="[[lidClosedManaged_]]"> | |
| 71 <template is="dom-repeat" items="[[lidClosedOptions_]]"> | |
| 72 <option value="[[item.value]]">[[item.name]]</option> | |
| 73 </template> | |
| 74 </select> | |
| 75 <span class="md-select-underline"></span> | |
| 76 </div> | |
| 77 </div> | |
| 38 </template> | 78 </template> |
| 39 <script src="power.js"></script> | 79 <script src="power.js"></script> |
| 40 </dom-module> | 80 </dom-module> |
| OLD | NEW |