Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2853113002: Infer types of double literals. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Infer types of double literals. I'm also adding simple_* tests for integer and double literals, because as it is now, existing tests are more complex, and we don't see whether these basic features work. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3604e6995122876f98de6cc52711c440374471b2

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add expectations for compile/outline pipelines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -4 lines) Patch
M pkg/front_end/lib/src/fasta/builder/ast_factory.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_ast_factory.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/simple_literal_double.dart View 1 chunk +12 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/simple_literal_double.dart.direct.expect View 1 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/simple_literal_double.dart.outline.expect View 1 1 chunk +6 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/simple_literal_double.dart.strong.expect View 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/simple_literal_int.dart View 1 chunk +12 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/simple_literal_int.dart.direct.expect View 1 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/simple_literal_int.dart.outline.expect View 1 1 chunk +6 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/simple_literal_int.dart.strong.expect View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 7 months ago (2017-05-01 20:18:29 UTC) #1
Paul Berry
Assuming additional expectation files are added, lgtm. https://codereview.chromium.org/2853113002/diff/1/pkg/front_end/testcases/inference/simple_literal_double.dart.strong.expect File pkg/front_end/testcases/inference/simple_literal_double.dart.strong.expect (right): https://codereview.chromium.org/2853113002/diff/1/pkg/front_end/testcases/inference/simple_literal_double.dart.strong.expect#newcode1 pkg/front_end/testcases/inference/simple_literal_double.dart.strong.expect:1: library test; ...
3 years, 7 months ago (2017-05-01 20:36:39 UTC) #2
scheglov
3 years, 7 months ago (2017-05-01 21:16:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3604e6995122876f98de6cc52711c440374471b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698