Issue 2853028: Mac: Enable fastbuild.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2853028: Mac: Enable fastbuild. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by Lei Zhang

Modified:
4 years ago

Reviewers:
Mark Mentovai - out til August

CC:
chromium-reviews, vandebo (ex-Chrome), M-A Ruel

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Mac: Enable fastbuild. BUG=none TEST=xcode passes -g1 to g++. TBR=mark Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51597

Patch Set 1 : one more time #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	build/common.gypi	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Trybot results: mac linux win

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

On 2010/07/03 08:48:59, Lei Zhang wrote: > TBR > > Attempting to revive Chromium Mac ...

4 years, 11 months ago (2010-07-03 09:15:15 UTC) #2

Mark Mentovai - out til August

4 years, 10 months ago (2010-07-07 17:03:39 UTC) #3

LGTM, but why set any -g at all? The backtraces won’t have any
function/file/line information available in the DWARF data. If it’s a debug
build, there will be symbols so function names will be available, but you’d get
those without -g. We don’t use -fomit-frame-pointer (and we never will in debug
builds) so debugging data is never necessary to assist backtracing. In release
builds, -g1 would eliminate even function names; it would allow the production
of a backtrace of -fomit-frame-pointer code (which we may one day have) but it’d
be useless without any other debugging data.

Expand Messages | Collapse Messages