[Extensions Bindings] Add native declarativeContent verification

chrome/browser/extensions/native_bindings_apitest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
 #include "chrome/browser/extensions/api/file_system/file_system_api.h"
@@ skipping 58 matching lines @@
   ready_listener.Reply(std::string());
   ASSERT_TRUE(close_listener.WaitUntilSatisfied());
   EXPECT_EQ("success", close_listener.message());
 }
 
 // Tests the declarativeContent API and declarative events.
 IN_PROC_BROWSER_TEST_F(NativeBindingsApiTest, DeclarativeEvents) {
   host_resolver()->AddRule("*", "127.0.0.1");
   embedded_test_server()->ServeFilesFromDirectory(test_data_dir_);
   ASSERT_TRUE(StartEmbeddedTestServer());
-  // Load an extension and wait for it to be ready.
+  // Load an extension. On load, this extension will a) run a few simple tests
+  // using chrome.test.runTests() and b) set up rules for declarative events for
+  // a browser-driven test. Wait for both the tests to finish and the extension
+  // to be ready.
   ExtensionTestMessageListener listener("ready", false);
+  ResultCatcher catcher;
   const Extension* extension = LoadExtension(
       test_data_dir_.AppendASCII("native_bindings/declarative_content"));
+  ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
   ASSERT_TRUE(extension);
   ASSERT_TRUE(listener.WaitUntilSatisfied());
 
   // The extension's page action should currently be hidden.
   ExtensionAction* page_action =
       ExtensionActionManager::Get(profile())->GetPageAction(*extension);
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   int tab_id = SessionTabHelper::IdForTab(web_contents);
   EXPECT_FALSE(page_action->GetIsVisible(tab_id));
+  EXPECT_TRUE(page_action->GetDeclarativeIcon(tab_id).IsEmpty());
 
   // Navigating to example.com should show the page action.
   ui_test_utils::NavigateToURL(
       browser(), embedded_test_server()->GetURL(
                      "example.com", "/native_bindings/simple.html"));
   base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(page_action->GetIsVisible(tab_id));
+  EXPECT_FALSE(page_action->GetDeclarativeIcon(tab_id).IsEmpty());
 
   // And the extension should be notified of the click.
   ExtensionTestMessageListener clicked_listener("clicked and removed", false);
   ExtensionActionAPI::Get(profile())->DispatchExtensionActionClicked(
       *page_action, web_contents);
   ASSERT_TRUE(clicked_listener.WaitUntilSatisfied());
 }
 
 IN_PROC_BROWSER_TEST_F(NativeBindingsApiTest, LazyListeners) {
   ProcessManager::SetEventPageIdleTimeForTesting(1);
@@ skipping 129 matching lines @@
   ui_test_utils::NavigateToURL(
       browser(), embedded_test_server()->GetURL(
                      "example.com", "/native_bindings/simple.html"));
 
   ExtensionTestMessageListener listener("callback", false);
   ASSERT_TRUE(LoadExtension(test_dir.UnpackedPath()));
   EXPECT_TRUE(listener.WaitUntilSatisfied());
 }
 
 }  // namespace extensions