Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2853001: Fix bug where auto-connect setting is not immediately saved.... (Closed)

Created:
10 years, 6 months ago by Charlie Lee
Modified:
9 years, 7 months ago
Reviewers:
zel
CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Fix bug where auto-connect setting is not immediately saved. Also fix Google-A wifi auto-reconnect to also try Google if Google-A is not available or not setup to auto-connect. BUG=chromium-os:3054 TEST=manual test. when you change auto-connect setting, make sure that it's set properly when you immediately open the network options dialog again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50161

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -35 lines) Patch
M chrome/browser/chromeos/cros/network_library.h View 1 2 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 1 6 chunks +48 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Charlie Lee
http://codereview.chromium.org/2853001/diff/1/2 File chrome/browser/chromeos/cros/network_library.cc (right): http://codereview.chromium.org/2853001/diff/1/2#newcode260 chrome/browser/chromeos/cros/network_library.cc:260: bool NetworkLibraryImpl::ConnectToPreferredNetworkIfAvailable() { I've tested this manually. Reconnect to ...
10 years, 6 months ago (2010-06-14 21:58:35 UTC) #1
Charlie Lee
Zel, I also added the fallback to use Google wifi if Google-A is not available. ...
10 years, 6 months ago (2010-06-16 22:59:30 UTC) #2
zel
10 years, 6 months ago (2010-06-17 05:40:04 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698