Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Unified Diff: runtime/vm/kernel_reader.h

Issue 2852943003: Move the Kernel string offsets into the VM's heap. (Closed)
Patch Set: Incorporate review comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/kernel_binary_flowgraph.cc ('k') | runtime/vm/kernel_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_reader.h
diff --git a/runtime/vm/kernel_reader.h b/runtime/vm/kernel_reader.h
index 7e3399b6eac44bfb2b3a2e06ff9620e3d63f47d4..4b54010d2cbe7971a0a683aa3b3ff1c0f0063e4d 100644
--- a/runtime/vm/kernel_reader.h
+++ b/runtime/vm/kernel_reader.h
@@ -67,11 +67,11 @@ class KernelReader {
void ReadLibrary(Library* kernel_library);
- const dart::String& DartSymbol(String* str) {
- return translation_helper_.DartSymbol(str);
+ const dart::String& DartSymbol(intptr_t string_index) {
+ return translation_helper_.DartSymbol(string_index);
}
- uint8_t CharacterAt(String* str, intptr_t index);
+ uint8_t CharacterAt(intptr_t string_index, intptr_t index);
private:
friend class BuildingTranslationHelper;
@@ -92,7 +92,7 @@ class KernelReader {
// Otherwise return klass.
const Object& ClassForScriptAt(const dart::Class& klass,
intptr_t source_uri_index);
- Script& ScriptAt(intptr_t source_uri_index, String* import_uri = NULL);
+ Script& ScriptAt(intptr_t source_uri_index, intptr_t import_uri = -1);
void GenerateFieldAccessors(const dart::Class& klass,
const dart::Field& field,
« no previous file with comments | « runtime/vm/kernel_binary_flowgraph.cc ('k') | runtime/vm/kernel_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698