Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: runtime/vm/kernel_binary_flowgraph.h

Issue 2852943003: Move the Kernel string offsets into the VM's heap. (Closed)
Patch Set: Incorporate review comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/kernel_binary.cc ('k') | runtime/vm/kernel_binary_flowgraph.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_binary_flowgraph.h
diff --git a/runtime/vm/kernel_binary_flowgraph.h b/runtime/vm/kernel_binary_flowgraph.h
index 3fd552d3faa4a27f572acdf9b93546658ebada32..d2ce8474055bfe7d57878bc4399a205f463ebdf8 100644
--- a/runtime/vm/kernel_binary_flowgraph.h
+++ b/runtime/vm/kernel_binary_flowgraph.h
@@ -65,8 +65,6 @@ class StreamingFlowGraphBuilder {
flow_graph_builder->zone_,
&flow_graph_builder->translation_helper_,
&flow_graph_builder->type_translator_),
- string_offset_count_(0),
- string_offsets_(NULL),
canonical_names_(NULL),
canonical_names_size_(-1),
canonical_names_entries_read_(0),
@@ -74,7 +72,6 @@ class StreamingFlowGraphBuilder {
virtual ~StreamingFlowGraphBuilder() {
delete reader_;
- delete[] string_offsets_;
// The canonical names themselves are not (yet) deallocated.
delete[] canonical_names_;
}
@@ -82,7 +79,6 @@ class StreamingFlowGraphBuilder {
Fragment BuildAt(intptr_t kernel_offset);
private:
- intptr_t GetStringOffset(intptr_t index);
CanonicalName* GetCanonicalName(intptr_t index);
intptr_t ReaderOffset();
@@ -97,10 +93,6 @@ class StreamingFlowGraphBuilder {
ScopeBuildingResult* scopes();
ParsedFunction* parsed_function();
- dart::String& DartSymbol(intptr_t str_index);
- dart::String& DartString(intptr_t str_index);
- String* KernelString(intptr_t str_index);
-
Fragment DebugStepCheck(TokenPosition position);
Fragment LoadLocal(LocalVariable* variable);
Fragment PushArgument();
@@ -132,19 +124,6 @@ class StreamingFlowGraphBuilder {
kernel::Reader* reader_;
StreamingConstantEvaluator constant_evaluator_;
- // We build a table that gives us the start and end offsets of all the strings
- // in the binary.
- //
- // The number of string offsets. Note that this is one more than the number
- // of strings in the binary.
- intptr_t string_offset_count_;
-
- // An array of offsets of size string_table_size_ + 1, in order to include the
- // end offset of the last string. The string with index N consists of the
- // UTF-8 encoded bytes stretching from string_table_offsets_[N] (enclusive) to
- // string_table_offsets_[N+1] (exclusive).
- intptr_t* string_offsets_;
-
CanonicalName** canonical_names_;
intptr_t canonical_names_size_;
intptr_t canonical_names_entries_read_;
« no previous file with comments | « runtime/vm/kernel_binary.cc ('k') | runtime/vm/kernel_binary_flowgraph.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698