Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: runtime/vm/object.h

Issue 2852943003: Move the Kernel string offsets into the VM's heap. (Closed)
Patch Set: Incorporate review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/kernel_to_il.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef RUNTIME_VM_OBJECT_H_ 5 #ifndef RUNTIME_VM_OBJECT_H_
6 #define RUNTIME_VM_OBJECT_H_ 6 #define RUNTIME_VM_OBJECT_H_
7 7
8 #include "include/dart_api.h" 8 #include "include/dart_api.h"
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "platform/utils.h" 10 #include "platform/utils.h"
(...skipping 3573 matching lines...) Expand 10 before | Expand all | Expand 10 after
3584 intptr_t col_offset() const { return raw_ptr()->col_offset_; } 3584 intptr_t col_offset() const { return raw_ptr()->col_offset_; }
3585 3585
3586 // The load time in milliseconds since epoch. 3586 // The load time in milliseconds since epoch.
3587 int64_t load_timestamp() const { return raw_ptr()->load_timestamp_; } 3587 int64_t load_timestamp() const { return raw_ptr()->load_timestamp_; }
3588 3588
3589 RawArray* compile_time_constants() const { 3589 RawArray* compile_time_constants() const {
3590 return raw_ptr()->compile_time_constants_; 3590 return raw_ptr()->compile_time_constants_;
3591 } 3591 }
3592 void set_compile_time_constants(const Array& value) const; 3592 void set_compile_time_constants(const Array& value) const;
3593 3593
3594 RawTypedData* kernel_strings() const { return raw_ptr()->kernel_strings_; } 3594 RawTypedData* kernel_string_offsets() const {
3595 void set_kernel_strings(const TypedData& strings) const; 3595 return raw_ptr()->kernel_string_offsets_;
3596 }
3597 void set_kernel_string_offsets(const TypedData& offsets) const;
3598
3599 RawTypedData* kernel_string_data() const {
3600 return raw_ptr()->kernel_string_data_;
3601 }
3602 void set_kernel_string_data(const TypedData& data) const;
3596 3603
3597 RawTokenStream* tokens() const { 3604 RawTokenStream* tokens() const {
3598 ASSERT(kind() != RawScript::kKernelTag); 3605 ASSERT(kind() != RawScript::kKernelTag);
3599 return raw_ptr()->tokens_; 3606 return raw_ptr()->tokens_;
3600 } 3607 }
3601 3608
3602 void set_line_starts(const Array& value) const; 3609 void set_line_starts(const Array& value) const;
3603 3610
3604 void set_debug_positions(const Array& value) const; 3611 void set_debug_positions(const Array& value) const;
3605 3612
(...skipping 5400 matching lines...) Expand 10 before | Expand all | Expand 10 after
9006 9013
9007 inline void TypeArguments::SetHash(intptr_t value) const { 9014 inline void TypeArguments::SetHash(intptr_t value) const {
9008 // This is only safe because we create a new Smi, which does not cause 9015 // This is only safe because we create a new Smi, which does not cause
9009 // heap allocation. 9016 // heap allocation.
9010 StoreSmi(&raw_ptr()->hash_, Smi::New(value)); 9017 StoreSmi(&raw_ptr()->hash_, Smi::New(value));
9011 } 9018 }
9012 9019
9013 } // namespace dart 9020 } // namespace dart
9014 9021
9015 #endif // RUNTIME_VM_OBJECT_H_ 9022 #endif // RUNTIME_VM_OBJECT_H_
OLDNEW
« no previous file with comments | « runtime/vm/kernel_to_il.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698