Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Side by Side Diff: runtime/vm/object.cc

Issue 2852943003: Move the Kernel string offsets into the VM's heap. (Closed)
Patch Set: Incorporate review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/become.h" 10 #include "vm/become.h"
(...skipping 9080 matching lines...) Expand 10 before | Expand all | Expand 10 after
9091 } 9091 }
9092 return token_stream.GenerateSource(); 9092 return token_stream.GenerateSource();
9093 } 9093 }
9094 9094
9095 9095
9096 void Script::set_compile_time_constants(const Array& value) const { 9096 void Script::set_compile_time_constants(const Array& value) const {
9097 StorePointer(&raw_ptr()->compile_time_constants_, value.raw()); 9097 StorePointer(&raw_ptr()->compile_time_constants_, value.raw());
9098 } 9098 }
9099 9099
9100 9100
9101 void Script::set_kernel_strings(const TypedData& strings) const { 9101 void Script::set_kernel_string_offsets(const TypedData& offsets) const {
9102 StorePointer(&raw_ptr()->kernel_strings_, strings.raw()); 9102 StorePointer(&raw_ptr()->kernel_string_offsets_, offsets.raw());
9103 } 9103 }
9104 9104
9105 9105
9106 void Script::set_kernel_string_data(const TypedData& data) const {
9107 StorePointer(&raw_ptr()->kernel_string_data_, data.raw());
9108 }
9109
9110
9106 RawGrowableObjectArray* Script::GenerateLineNumberArray() const { 9111 RawGrowableObjectArray* Script::GenerateLineNumberArray() const {
9107 Zone* zone = Thread::Current()->zone(); 9112 Zone* zone = Thread::Current()->zone();
9108 const GrowableObjectArray& info = 9113 const GrowableObjectArray& info =
9109 GrowableObjectArray::Handle(zone, GrowableObjectArray::New()); 9114 GrowableObjectArray::Handle(zone, GrowableObjectArray::New());
9110 const String& source = String::Handle(zone, Source()); 9115 const String& source = String::Handle(zone, Source());
9111 const String& key = Symbols::Empty(); 9116 const String& key = Symbols::Empty();
9112 const Object& line_separator = Object::Handle(zone); 9117 const Object& line_separator = Object::Handle(zone);
9113 Smi& value = Smi::Handle(zone); 9118 Smi& value = Smi::Handle(zone);
9114 9119
9115 if (kind() == RawScript::kKernelTag) { 9120 if (kind() == RawScript::kKernelTag) {
(...skipping 14199 matching lines...) Expand 10 before | Expand all | Expand 10 after
23315 return UserTag::null(); 23320 return UserTag::null();
23316 } 23321 }
23317 23322
23318 23323
23319 const char* UserTag::ToCString() const { 23324 const char* UserTag::ToCString() const {
23320 const String& tag_label = String::Handle(label()); 23325 const String& tag_label = String::Handle(label());
23321 return tag_label.ToCString(); 23326 return tag_label.ToCString();
23322 } 23327 }
23323 23328
23324 } // namespace dart 23329 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698