Move the Kernel string offsets into the VM's heap.

runtime/vm/kernel_to_il.h

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_KERNEL_TO_IL_H_
 #define RUNTIME_VM_KERNEL_TO_IL_H_
 
 #if !defined(DART_PRECOMPILED_RUNTIME)
 
 #include "vm/growable_array.h"
@@ skipping 263 matching lines @@
 
   Thread* thread() { return thread_; }
 
   Zone* zone() { return zone_; }
 
   Isolate* isolate() { return isolate_; }
 
   Heap::Space allocation_space() { return allocation_space_; }
 
   // Access to strings.
+  const TypedData& string_offsets() { return string_offsets_; }
+  void SetStringOffsets(const TypedData& string_data);
+
   const TypedData& string_data() { return string_data_; }
   void SetStringData(const TypedData& string_data);
-  uint8_t CharacterAt(String* str, intptr_t index);
-  bool StringEquals(String* str, const char* other);
+
+  intptr_t StringOffset(intptr_t string_index) const;
+  intptr_t StringSize(intptr_t string_index) const;
+  uint8_t CharacterAt(intptr_t string_index, intptr_t index);
+  bool StringEquals(intptr_t string_index, const char* other);
 
   // Predicates on CanonicalNames.
   bool IsAdministrative(CanonicalName* name);
   bool IsPrivate(CanonicalName* name);
   bool IsRoot(CanonicalName* name);
   bool IsLibrary(CanonicalName* name);
   bool IsClass(CanonicalName* name);
   bool IsMember(CanonicalName* name);
   bool IsField(CanonicalName* name);
   bool IsConstructor(CanonicalName* name);
   bool IsProcedure(CanonicalName* name);
   bool IsMethod(CanonicalName* name);
   bool IsGetter(CanonicalName* name);
   bool IsSetter(CanonicalName* name);
   bool IsFactory(CanonicalName* name);
 
   // For a member (field, constructor, or procedure) return the canonical name
   // of the enclosing class or library.
   CanonicalName* EnclosingName(CanonicalName* name);
 
   RawInstance* Canonicalize(const Instance& instance);
 
   const dart::String& DartString(const char* content) {
     return DartString(content, allocation_space_);
   }
   const dart::String& DartString(const char* content, Heap::Space space);
 
-  dart::String& DartString(String* content) {
-    return DartString(content, allocation_space_);
+  dart::String& DartString(intptr_t string_index) {
+    return DartString(string_index, allocation_space_);
   }
-  dart::String& DartString(String* content, Heap::Space space);
+  dart::String& DartString(intptr_t string_index, Heap::Space space);
 
   dart::String& DartString(const uint8_t* utf8_array, intptr_t len) {
     return DartString(utf8_array, len, allocation_space_);
   }
   dart::String& DartString(const uint8_t* utf8_array,
                            intptr_t len,
                            Heap::Space space);
 
   const dart::String& DartSymbol(const char* content) const;
-  dart::String& DartSymbol(String* content) const;
+  dart::String& DartSymbol(intptr_t string_index) const;
   dart::String& DartSymbol(const uint8_t* utf8_array, intptr_t len) const;
 
   const dart::String& DartClassName(CanonicalName* kernel_class);
 
   const dart::String& DartConstructorName(CanonicalName* constructor);
 
   const dart::String& DartProcedureName(CanonicalName* procedure);
 
   const dart::String& DartSetterName(CanonicalName* setter);
   const dart::String& DartSetterName(Name* setter_name);
@@ skipping 32 matching lines @@
 
  private:
   // This will mangle [name_to_modify] if necessary and make the result a symbol
   // if asked.  The result will be available in [name_to_modify] and it is also
   // returned.  If the name is private, the canonical name [parent] will be used
   // to get the import URI of the library where the name is visible.
   dart::String& ManglePrivateName(CanonicalName* parent,
                                   dart::String* name_to_modify,
                                   bool symbolize = true);
 
-  const dart::String& DartSetterName(CanonicalName* parent, String* setter);
-  const dart::String& DartGetterName(CanonicalName* parent, String* getter);
-  const dart::String& DartMethodName(CanonicalName* parent, String* method);
+  const dart::String& DartSetterName(CanonicalName* parent, intptr_t setter);
+  const dart::String& DartGetterName(CanonicalName* parent, intptr_t getter);
+  const dart::String& DartMethodName(CanonicalName* parent, intptr_t method);
 
   Thread* thread_;
   Zone* zone_;
   Isolate* isolate_;
   Heap::Space allocation_space_;
 
+  TypedData& string_offsets_;
   TypedData& string_data_;
 };
 
 // Regarding malformed types:
 // The spec says in section "19.1 Static Types" roughly:
 //
 //   A type T is malformed iff:
 //     * T does not denote a type in scope
 //     * T refers to a type parameter in a static member
 //     * T is a parametrized Type G<T1, ...> and G is malformed
@@ skipping 748 matching lines @@
 namespace kernel {
 
 RawObject* EvaluateMetadata(const dart::Field& metadata_field);
 RawObject* BuildParameterDescriptor(TreeNode* const kernel_node);
 
 }  // namespace kernel
 }  // namespace dart
 
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)
 #endif  // RUNTIME_VM_KERNEL_TO_IL_H_