Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 285293008: Disable poppler on Windows (Closed)

Created:
6 years, 7 months ago by robertphillips
Modified:
6 years, 7 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Disable poppler on Windows since it no longer compiles in VS2013 Committed: http://code.google.com/p/skia/source/detail?r=14764

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gyp/common_variables.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 7 months ago (2014-05-16 16:24:27 UTC) #1
borenet
LGTM ¯\_(ツ)_/¯
6 years, 7 months ago (2014-05-16 16:28:13 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 7 months ago (2014-05-16 16:30:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/285293008/1
6 years, 7 months ago (2014-05-16 16:30:41 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 16:35:50 UTC) #5
Message was sent while issue was closed. 
Change committed as 14764

Powered by Google App Engine
This is Rietveld 408576698