Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 285293007: Fix layoutOverflowRect in case of explicit 'overflow: scroll', but no overflow content (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderBox.cpp
diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp
index c1e5be5dd91567fc3f2fe9a50c3f3e0474d08727..28b135dd0fe110afcbf93c914c96ade9e8077aed 100644
--- a/Source/core/rendering/RenderBox.cpp
+++ b/Source/core/rendering/RenderBox.cpp
@@ -4269,12 +4269,8 @@ void RenderBox::addContentsVisualOverflow(const LayoutRect& rect)
return;
}
- if (!m_overflow) {
- LayoutRect clientBox = clientBoxRect();
- if (style()->shouldPlaceBlockDirectionScrollbarOnLogicalLeft())
- clientBox.move(-verticalScrollbarWidth(), 0);
- m_overflow = adoptPtr(new RenderOverflow(clientBox, borderBoxRect()));
- }
+ if (!m_overflow)
+ m_overflow = adoptPtr(new RenderOverflow(clientBoxRect(), borderBoxRect()));
Julien - ping for review 2014/05/19 14:36:19 This should be noOverflowRect() to match the rest
pals 2014/05/20 09:20:19 Done.
m_overflow->addContentsVisualOverflow(rect);
}

Powered by Google App Engine
This is Rietveld 408576698