Replace content's faviconURL with components/favicon's

Replace content's faviconURL with components/favicon's

BUG=359586
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271367

[jif-google, 2014-05-15 18:34:19]

PTAL

[blundell, 2014-05-16 07:33:30]

LGTM with suggestion that could be addressed in followup

https://codereview.chromium.org/285293005/diff/20001/chrome/browser/favicon/f...
File chrome/browser/favicon/favicon_tab_helper.cc (right):

https://codereview.chromium.org/285293005/diff/20001/chrome/browser/favicon/f...
chrome/browser/favicon/favicon_tab_helper.cc:228: favicon_base::IconType
ToChromeIconType(
This conversion function seems like it would make would more sense as a static
function in //components/favicon_base/content, something like
|FaviconBaseIconTypeFromContentIconType|. WDYT?

[jif, 2014-05-16 17:32:30]

https://codereview.chromium.org/285293005/diff/20001/chrome/browser/favicon/f...
File chrome/browser/favicon/favicon_tab_helper.cc (right):

https://codereview.chromium.org/285293005/diff/20001/chrome/browser/favicon/f...
chrome/browser/favicon/favicon_tab_helper.cc:228: favicon_base::IconType
ToChromeIconType(
On 2014/05/16 07:33:30, blundell wrote:
> This conversion function seems like it would make would more sense as a static
> function in //components/favicon_base/content, something like
> |FaviconBaseIconTypeFromContentIconType|. WDYT?

I agree.
Added TODO.

[jif, 2014-05-17 07:25:36]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2014-05-17 07:27:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jif@chromium.org/285293005/40001

[commit-bot: I haz the power, 2014-05-17 13:29:46]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-05-17 13:33:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-17 13:33:01]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[jif, 2014-05-19 08:11:36]

The CQ bit was checked by jif@chromium.org

[commit-bot: I haz the power, 2014-05-19 08:12:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jif@chromium.org/285293005/60001

[commit-bot: I haz the power, 2014-05-19 11:43:59]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-19 12:42:40]

Change committed as 271367