chrome/browser/component_updater/test/cld_component_installer_unittest.cc - Issue 285293004: Allow browser tests to run with dynamic CLD data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/test/cld_component_installer_unittest.cc

Issue 285293004: Allow browser tests to run with dynamic CLD data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cld_uma

Patch Set: Yet more #ifdefs for compiler cleanliness Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/cld_component_installer.cc ('k') | chrome/browser/translate/translate_browser_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/test/cld_component_installer_unittest.cc

diff --git a/chrome/browser/component_updater/test/cld_component_installer_unittest.cc b/chrome/browser/component_updater/test/cld_component_installer_unittest.cc

index 67803df49d36d01b1d599a59028bf0bd2c217036..6fc4f14b73b4dcd57bae5db09d4c016425f926fc 100644

--- a/chrome/browser/component_updater/test/cld_component_installer_unittest.cc

+++ b/chrome/browser/component_updater/test/cld_component_installer_unittest.cc

@@ -76,7 +76,8 @@ TEST_F(CldComponentInstallerTest, OnCustomInstall) {

TEST_F(CldComponentInstallerTest, GetInstalledPath) {

const base::FilePath base_dir;

- const base::FilePath result = traits.GetInstalledPath(base_dir);

+ const base::FilePath result =

+ CldComponentInstallerTraits::GetInstalledPath(base_dir);

ASSERT_TRUE(EndsWith(result.value(), chrome::kCLDDataFilename, true));

}