Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 285293003: Cleanup: One more round of removing unused flag resources or marking them as platform-specific. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: One more round of removing unused flag resources or marking them as platform-specific. R=aurimas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -45 lines) Patch
M chrome/app/generated_resources.grd View 11 chunks +51 lines, -45 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
We are getting close.
6 years, 7 months ago (2014-05-15 07:00:23 UTC) #1
aurimas (slooooooooow)
lgtm
6 years, 7 months ago (2014-05-15 23:03:49 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-19 19:18:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/285293003/1
6 years, 7 months ago (2014-05-19 19:19:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 22:46:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 22:51:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68502)
6 years, 7 months ago (2014-05-19 22:51:42 UTC) #7
Lei Zhang
6 years, 7 months ago (2014-05-19 23:15:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r271512 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698