Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Side by Side Diff: src/builtins/builtins.h

Issue 2852833002: [builtins] De-duplicate specification of array builtin parameter count (Closed)
Patch Set: Finally Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | src/builtins/builtins.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_BUILTINS_BUILTINS_H_ 5 #ifndef V8_BUILTINS_BUILTINS_H_
6 #define V8_BUILTINS_BUILTINS_H_ 6 #define V8_BUILTINS_BUILTINS_H_
7 7
8 #include "src/base/flags.h" 8 #include "src/base/flags.h"
9 #include "src/builtins/builtins-definitions.h" 9 #include "src/builtins/builtins-definitions.h"
10 #include "src/globals.h" 10 #include "src/globals.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 Code* builtin(Name name) { 69 Code* builtin(Name name) {
70 // Code::cast cannot be used here since we access builtins 70 // Code::cast cannot be used here since we access builtins
71 // during the marking phase of mark sweep. See IC::Clear. 71 // during the marking phase of mark sweep. See IC::Clear.
72 return reinterpret_cast<Code*>(builtins_[name]); 72 return reinterpret_cast<Code*>(builtins_[name]);
73 } 73 }
74 74
75 Address builtin_address(Name name) { 75 Address builtin_address(Name name) {
76 return reinterpret_cast<Address>(&builtins_[name]); 76 return reinterpret_cast<Address>(&builtins_[name]);
77 } 77 }
78 78
79 static int GetBuiltinParameterCount(Name name);
80
79 static Callable CallableFor(Isolate* isolate, Name name); 81 static Callable CallableFor(Isolate* isolate, Name name);
80 82
81 static const char* name(int index); 83 static const char* name(int index);
82 84
83 // Returns the C++ entry point for builtins implemented in C++, and the null 85 // Returns the C++ entry point for builtins implemented in C++, and the null
84 // Address otherwise. 86 // Address otherwise.
85 static Address CppEntryOf(int index); 87 static Address CppEntryOf(int index);
86 88
87 static bool IsCpp(int index); 89 static bool IsCpp(int index);
88 static bool IsApi(int index); 90 static bool IsApi(int index);
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 friend class Isolate; 153 friend class Isolate;
152 friend class SetupIsolateDelegate; 154 friend class SetupIsolateDelegate;
153 155
154 DISALLOW_COPY_AND_ASSIGN(Builtins); 156 DISALLOW_COPY_AND_ASSIGN(Builtins);
155 }; 157 };
156 158
157 } // namespace internal 159 } // namespace internal
158 } // namespace v8 160 } // namespace v8
159 161
160 #endif // V8_BUILTINS_BUILTINS_H_ 162 #endif // V8_BUILTINS_BUILTINS_H_
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/builtins/builtins.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698