[builtins] De-duplicate specification of array builtin parameter count

src/builtins/builtins.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/api.h"
 #include "src/assembler-inl.h"
 #include "src/builtins/builtins-descriptors.h"
 #include "src/callable.h"
 #include "src/isolate.h"
@@ skipping 98 matching lines @@
     case OrdinaryToPrimitiveHint::kNumber:
       return OrdinaryToPrimitive_Number();
     case OrdinaryToPrimitiveHint::kString:
       return OrdinaryToPrimitive_String();
   }
   UNREACHABLE();
   return Handle<Code>::null();
 }
 
 // static
+int Builtins::GetBuiltinParameterCount(Isolate* isolate, Name name) {

[Igor Sheludko, 2017/05/02 09:31:16]

The |isolate| parameter can be removed.

+  switch (name) {
+#define CASE(Name, ParamCount, ...) \

[Igor Sheludko, 2017/05/02 09:31:16]

Please s/CASE/TFJ_CASE/ for better readability.

+  case k##Name: {                   \
+    return ParamCount;              \
+  }
+    BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, CASE, IGNORE_BUILTIN,
+                 IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN)
+#undef CASE
+    default:
+      UNREACHABLE();
+      return 0;
+  }
+}
+
+// static
 Callable Builtins::CallableFor(Isolate* isolate, Name name) {
   switch (name) {
 #define CASE(Name, ...)                                              \
   case k##Name: {                                                    \
     Handle<Code> code = isolate->builtins()->Name();                 \
     auto descriptor = Builtin_##Name##_InterfaceDescriptor(isolate); \
     return Callable(code, descriptor);                               \
   }
     BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, CASE, CASE,
                  CASE, IGNORE_BUILTIN, IGNORE_BUILTIN)
@@ skipping 110 matching lines @@
   // TODO(jochen): Remove this.
   if (responsible_context.is_null()) {
     return true;
   }
   if (*responsible_context == target->context()) return true;
   return isolate->MayAccess(responsible_context, target_global_proxy);
 }
 
 }  // namespace internal
 }  // namespace v8