Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11170)

Unified Diff: chrome/test/security_tests/sandbox_browsertest_linux.cc

Issue 285283003: Remove flag --test-sandbox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed directory, gyp and isolate refs Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/security_tests/sandbox_browsertest_linux.cc
diff --git a/chrome/test/security_tests/sandbox_browsertest_linux.cc b/chrome/test/security_tests/sandbox_browsertest_linux.cc
deleted file mode 100644
index f51db555bfcc6401e3888796f4d1cb2f9f8e3a4a..0000000000000000000000000000000000000000
--- a/chrome/test/security_tests/sandbox_browsertest_linux.cc
+++ /dev/null
@@ -1,34 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/test/base/in_process_browser_test.h"
-#include "content/public/browser/zygote_host_linux.h"
-#include "content/public/common/sandbox_linux.h"
-
-typedef InProcessBrowserTest SandboxLinuxTest;
-
-// Both the SUID sandbox (http://crbug.com/137653) and the Seccomp-BPF sandbox
-// are currently incompatible with ASan.
-#if defined(OS_LINUX) && !defined(ADDRESS_SANITIZER)
-#define MAYBE_SandboxStatus \
- SandboxStatus
-#else
-#define MAYBE_SandboxStatus \
- DISABLED_SandboxStatus
-#endif
-
-IN_PROC_BROWSER_TEST_F(SandboxLinuxTest, MAYBE_SandboxStatus) {
jln (very slow on Chromium) 2014/05/22 21:04:54 Let's keep this around please.
luken 2014/05/28 19:19:39 Can we move it to somewhere other than security_te
- // Get expected sandboxing status of renderers.
- const int status = content::ZygoteHost::GetInstance()->GetSandboxStatus();
-
- // The setuid sandbox is required as our first-layer sandbox.
- bool good_layer1 = status & content::kSandboxLinuxSUID &&
- status & content::kSandboxLinuxPIDNS &&
- status & content::kSandboxLinuxNetNS;
- // A second-layer sandbox is also required to be adequately sandboxed.
- bool good_layer2 = status & content::kSandboxLinuxSeccompBPF;
-
- EXPECT_TRUE(good_layer1);
- EXPECT_TRUE(good_layer2);
-}

Powered by Google App Engine
This is Rietveld 408576698