content/browser/renderer_host/render_process_host_impl.cc - Issue 2852803002: Remove base::SharedMemory::ShareToProcess.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2852803002: Remove base::SharedMemory::ShareToProcess. (Closed)

Patch Set: Compile error. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_process_host_impl.cc

diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc

index 5a4606baac194535c12e27e9f4890620cc4bdbee..2e02bab1fa03d50cb974e236fbcec85039094a2f 100644

--- a/content/browser/renderer_host/render_process_host_impl.cc

+++ b/content/browser/renderer_host/render_process_host_impl.cc

@@ -2745,8 +2745,8 @@ void RenderProcessHostImpl::CreateSharedRendererHistogramAllocator() {

std::move(shm), GetID(), "RendererMetrics", /*readonly=*/false));

}

- base::SharedMemoryHandle shm_handle;

- metrics_allocator_->shared_memory()->ShareToProcess(destination, &shm_handle);

+ base::SharedMemoryHandle shm_handle =

+ metrics_allocator_->shared_memory()->handle().Duplicate();

Send(new ChildProcessMsg_SetHistogramMemory(

shm_handle, metrics_allocator_->shared_memory()->mapped_size()));

}