Remove base::SharedMemory::ShareToProcess.

media/gpu/video_decode_accelerator_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The bulk of this file is support code; sorry about that.  Here's an overview
 // to hopefully help readers of this code:
 // - RenderingHelper is charged with interacting with X11/{EGL/GLES2,GLX/GL} or
 //   Win/EGL.
 // - ClientState is an enum for the state of the decode client used by the test.
 // - ClientStateNotification is a barrier abstraction that allows the test code
@@ skipping 1067 matching lines @@
         next_fragment_size, profile_);
     if (reset_here)
       reset_after_frame_num_ = END_OF_STREAM_RESET;
   }
 
   // Populate the shared memory buffer w/ the fragment, duplicate its handle,
   // and hand it off to the decoder.
   base::SharedMemory shm;
   LOG_ASSERT(shm.CreateAndMapAnonymous(next_fragment_size));
   memcpy(shm.memory(), next_fragment_bytes.data(), next_fragment_size);
-  base::SharedMemoryHandle dup_handle;
-  bool result =
-      shm.ShareToProcess(base::GetCurrentProcessHandle(), &dup_handle);
-  LOG_ASSERT(result);
+  base::SharedMemoryHandle dup_handle = shm.handle().Duplicate();
+  LOG_ASSERT(dup_handle.IsValid());
   BitstreamBuffer bitstream_buffer(next_bitstream_buffer_id_, dup_handle,

[Nico, 2017/05/02 20:08:01]

I tried to verify that BitstreamBuffer assumes ownership, and from what I can
tell it doesn't. Please check and add TODO if you too think that this leaks.

[erikchen, 2017/05/02 21:33:10]

Added a TODO

                                    next_fragment_size);
   decode_start_time_[next_bitstream_buffer_id_] = base::TimeTicks::Now();
   // Mask against 30 bits, to avoid (undefined) wraparound on signed integer.
   next_bitstream_buffer_id_ = (next_bitstream_buffer_id_ + 1) & 0x3FFFFFFF;
   decoder_->Decode(bitstream_buffer);
   ++outstanding_decodes_;
   if (!remaining_play_throughs_ &&
       -delete_decoder_state_ == next_bitstream_buffer_id_) {
     DeleteDecoder();
   }
@@ skipping 812 matching lines @@
       media::g_thumbnail_output_dir = base::FilePath(it->second.c_str());
     }
   }
 
   base::ShadowingAtExitManager at_exit_manager;
 
   return base::LaunchUnitTestsSerially(
       argc, argv,
       base::Bind(&media::VDATestSuite::Run, base::Unretained(&test_suite)));
 }