Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: media/audio/audio_input_device_unittest.cc

Issue 2852803002: Remove base::SharedMemory::ShareToProcess. (Closed)
Patch Set: Rebase. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ptr_util.h" 5 #include "base/memory/ptr_util.h"
6 #include "base/memory/shared_memory.h" 6 #include "base/memory/shared_memory.h"
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/process/process_handle.h" 8 #include "base/process/process_handle.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 AudioBus::CalculateMemorySize(params); 113 AudioBus::CalculateMemorySize(params);
114 114
115 ASSERT_TRUE(shared_memory.CreateAndMapAnonymous(memory_size)); 115 ASSERT_TRUE(shared_memory.CreateAndMapAnonymous(memory_size));
116 memset(shared_memory.memory(), 0xff, memory_size); 116 memset(shared_memory.memory(), 0xff, memory_size);
117 117
118 ASSERT_TRUE( 118 ASSERT_TRUE(
119 CancelableSyncSocket::CreatePair(&browser_socket, &renderer_socket)); 119 CancelableSyncSocket::CreatePair(&browser_socket, &renderer_socket));
120 SyncSocket::TransitDescriptor audio_device_socket_descriptor; 120 SyncSocket::TransitDescriptor audio_device_socket_descriptor;
121 ASSERT_TRUE(renderer_socket.PrepareTransitDescriptor( 121 ASSERT_TRUE(renderer_socket.PrepareTransitDescriptor(
122 base::GetCurrentProcessHandle(), &audio_device_socket_descriptor)); 122 base::GetCurrentProcessHandle(), &audio_device_socket_descriptor));
123 base::SharedMemoryHandle duplicated_memory_handle; 123 base::SharedMemoryHandle duplicated_memory_handle =
124 ASSERT_TRUE(shared_memory.ShareToProcess(base::GetCurrentProcessHandle(), 124 shared_memory.handle().Duplicate();
125 &duplicated_memory_handle)); 125 ASSERT_TRUE(duplicated_memory_handle.IsValid());
126 126
127 base::MessageLoopForIO io_loop; 127 base::MessageLoopForIO io_loop;
128 MockCaptureCallback callback; 128 MockCaptureCallback callback;
129 MockAudioInputIPC* input_ipc = new MockAudioInputIPC(); 129 MockAudioInputIPC* input_ipc = new MockAudioInputIPC();
130 scoped_refptr<AudioInputDevice> device( 130 scoped_refptr<AudioInputDevice> device(
131 new AudioInputDevice(base::WrapUnique(input_ipc), io_loop.task_runner())); 131 new AudioInputDevice(base::WrapUnique(input_ipc), io_loop.task_runner()));
132 device->Initialize(params, &callback, 1); 132 device->Initialize(params, &callback, 1);
133 device->Start(); 133 device->Start();
134 134
135 EXPECT_CALL(*input_ipc, CreateStream(_, _, _, _, _)) 135 EXPECT_CALL(*input_ipc, CreateStream(_, _, _, _, _))
136 .WillOnce(ReportOnStreamCreated( 136 .WillOnce(ReportOnStreamCreated(
137 device.get(), duplicated_memory_handle, 137 device.get(), duplicated_memory_handle,
Nico 2017/05/02 20:08:01 Since this is mocked out, we probably leak duplica
erikchen 2017/05/02 21:33:10 I added a Close() to the end of this test.
138 SyncSocket::UnwrapHandle(audio_device_socket_descriptor), memory_size, 138 SyncSocket::UnwrapHandle(audio_device_socket_descriptor), memory_size,
139 1)); 139 1));
140 EXPECT_CALL(*input_ipc, RecordStream()); 140 EXPECT_CALL(*input_ipc, RecordStream());
141 EXPECT_CALL(callback, OnCaptureStarted()) 141 EXPECT_CALL(callback, OnCaptureStarted())
142 .WillOnce(QuitLoop(io_loop.task_runner())); 142 .WillOnce(QuitLoop(io_loop.task_runner()));
143 base::RunLoop().Run(); 143 base::RunLoop().Run();
144 device->Stop(); 144 device->Stop();
145 base::RunLoop().RunUntilIdle(); 145 base::RunLoop().RunUntilIdle();
146 } 146 }
147 147
148 } // namespace media. 148 } // namespace media.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698