Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2852783002: Revert of Allow Windows to return a monitor out of the first quadrant (Closed)

Created:
3 years, 7 months ago by Hzj_jie
Modified:
3 years, 7 months ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Allow Windows to return a monitor out of the first quadrant (patchset #2 id:60001 of https://codereview.chromium.org/2848443004/ ) Reason for revert: TranslateRect() is placed in a wrong position. Original issue's description: > Allow Windows to return a monitor out of the first quadrant > > Windows may return a DesktopCoordinate out of the first quadrant > (x >= 0 && y >= 0), this typically happens when the primary and secondary > monitors are swapped. i.e. The secondary monitor is on the left but the primary > one is on the right. > This change "moves" the entire screen from any quadrant to the (0, 0), so we can > capture the monitors in other quadrants. > > BUG=chromium:715689 > > Review-Url: https://codereview.webrtc.org/2848443004 > Cr-Commit-Position: refs/heads/master@{#17935} > Committed: https://chromium.googlesource.com/external/webrtc/+/049ec71e657eef3d15e0f15d60acb1a71e81b521 TBR=sergeyu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:715689 Review-Url: https://codereview.webrtc.org/2852783002 Cr-Commit-Position: refs/heads/master@{#17936} Committed: https://chromium.googlesource.com/external/webrtc/+/7aea6afdab29f07c8cd3022529a14894ca294811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -41 lines) Patch
M webrtc/modules/desktop_capture/win/dxgi_adapter_duplicator.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_adapter_duplicator.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.h View 2 chunks +3 lines, -7 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_duplicator_controller.cc View 3 chunks +1 line, -11 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h View 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/modules/desktop_capture/win/dxgi_output_duplicator.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Hzj_jie
Created Revert of Allow Windows to return a monitor out of the first quadrant
3 years, 7 months ago (2017-04-28 21:30:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2852783002/1
3 years, 7 months ago (2017-04-28 21:30:53 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 21:31:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7aea6afdab29f07c8cd302252...

Powered by Google App Engine
This is Rietveld 408576698