Delete JumpList temp file when failing to write the icon's content to it

chrome/browser/win/jumplist.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/win/jumplist.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 95 matching lines @@
   if (!image_skia.isNull()) {
     std::vector<float> supported_scales = image_skia.GetSupportedScales();
     for (auto& scale : supported_scales) {
       gfx::ImageSkiaRep image_skia_rep = image_skia.GetRepresentation(scale);
       if (!image_skia_rep.is_null())
         image_family.Add(
             gfx::Image::CreateFrom1xBitmap(image_skia_rep.sk_bitmap()));
     }
   }
 
+  // If it fails to write the icon's content into the empty temp file just
+  // created at |path|, delete the temp file to avoid leakage.
   if (!IconUtil::CreateIconFileFromImageFamily(image_family, path,
-                                               IconUtil::NORMAL_WRITE))
+                                               IconUtil::NORMAL_WRITE)) {
+    base::DeleteFile(path, false);

[grt (UTC plus 2), 2017/05/01 08:47:32]

nit: put the comment above DeleteFile rather than above the condition. maybe
simplify to:
    // Delete the file created by CreateTemporaryFileInDir since it will not be
used.

[chengx, 2017/05/01 18:05:47]

Done.

     return false;
+  }
 
   // Add this icon file to the list and return its absolute path.
   // The IShellLink::SetIcon() function needs the absolute path to an icon.
   *icon_path = path;
   return true;
 }
 
 // Helper method for RunUpdate to create icon files for the asynchrounously
 // loaded icons.
 void CreateIconFiles(const base::FilePath& icon_dir,
@@ skipping 572 matching lines @@
 void JumpList::TopSitesLoaded(history::TopSites* top_sites) {
 }
 
 void JumpList::TopSitesChanged(history::TopSites* top_sites,
                                ChangeReason change_reason) {
   top_sites->GetMostVisitedURLs(
       base::Bind(&JumpList::OnMostVisitedURLsAvailable,
                  weak_ptr_factory_.GetWeakPtr()),
       false);
 }