Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 2852723002: dart:mirrors workaround for generic methods (Closed)

Created:
3 years, 7 months ago by vsm
Modified:
3 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart:mirrors workaround for generic methods Fixes #29509 R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/7bedf63e1e541e5ba28c165ca6918fe96fb5e025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart View 2 chunks +5 lines, -5 lines 0 comments Download
A tests/lib_strong/mirrors/generic_method_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 7 months ago (2017-04-29 00:16:40 UTC) #3
Jennifer Messerly
lgtm
3 years, 7 months ago (2017-04-29 00:54:38 UTC) #4
vsm
3 years, 7 months ago (2017-04-29 03:02:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7bedf63e1e541e5ba28c165ca6918fe96fb5e025 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698