Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: chrome/browser/ui/search/search_ipc_router.h

Issue 2852693002: Remove DetermineIfPageSupportsInstant and all its plumbing (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/search/instant_tab_unittest.cc ('k') | chrome/browser/ui/search/search_ipc_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/search_ipc_router.h
diff --git a/chrome/browser/ui/search/search_ipc_router.h b/chrome/browser/ui/search/search_ipc_router.h
index 541e27741d6073efe84a7d3f4a43794c08173374..548511ee1637f21edd6a6f334d8ac79e90ed0541 100644
--- a/chrome/browser/ui/search/search_ipc_router.h
+++ b/chrome/browser/ui/search/search_ipc_router.h
@@ -19,7 +19,6 @@
#include "components/omnibox/common/omnibox_focus_state.h"
#include "content/public/browser/web_contents_binding_set.h"
#include "content/public/browser/web_contents_observer.h"
-#include "ui/base/window_open_disposition.h"
class GURL;
@@ -40,6 +39,7 @@ class SearchIPCRouter : public content::WebContentsObserver,
public:
// Called upon determination of Instant API support in response to the page
// load event.
+ // TODO(treib): Remove this. crbug.com/627747
virtual void OnInstantSupportDetermined(bool supports_instant) = 0;
// Called when the page wants the omnibox to be focused. |state| specifies
@@ -136,11 +136,6 @@ class SearchIPCRouter : public content::WebContentsObserver,
// Tells the SearchIPCRouter that a new page in an Instant process committed.
void OnNavigationEntryCommitted();
- // Tells the renderer to determine if the page supports the Instant API, which
- // results in a call to OnInstantSupportDetermined() when the reply is
- // received.
- void DetermineIfPageSupportsInstant();
-
// Tells the renderer about the result of the Chrome identity check.
void SendChromeIdentityCheckResult(const base::string16& identity,
bool identity_match);
@@ -175,8 +170,6 @@ class SearchIPCRouter : public content::WebContentsObserver,
void OnTabDeactivated();
// chrome::mojom::Instant:
- void InstantSupportDetermined(int page_seq_no,
- bool supports_instant) override;
void FocusOmnibox(int page_id, OmniboxFocusState state) override;
void DeleteMostVisitedItem(int page_seq_no, const GURL& url) override;
void UndoMostVisitedDeletion(int page_seq_no, const GURL& url) override;
@@ -207,10 +200,6 @@ class SearchIPCRouter : public content::WebContentsObserver,
friend class SearchIPCRouterPolicyTest;
friend class SearchIPCRouterTest;
FRIEND_TEST_ALL_PREFIXES(SearchTabHelperTest,
- DetermineIfPageSupportsInstant_Local);
- FRIEND_TEST_ALL_PREFIXES(SearchTabHelperTest,
- DetermineIfPageSupportsInstant_NonLocal);
- FRIEND_TEST_ALL_PREFIXES(SearchTabHelperTest,
PageURLDoesntBelongToInstantRenderer);
FRIEND_TEST_ALL_PREFIXES(SearchIPCRouterTest,
IgnoreMessageIfThePageIsNotActive);
« no previous file with comments | « chrome/browser/ui/search/instant_tab_unittest.cc ('k') | chrome/browser/ui/search/search_ipc_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698