Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: chrome/common/instant.mojom

Issue 2852693002: Remove DetermineIfPageSupportsInstant and all its plumbing (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module chrome.mojom; 5 module chrome.mojom;
6 6
7 import "mojo/common/string16.mojom"; 7 import "mojo/common/string16.mojom";
8 import "mojo/common/time.mojom"; 8 import "mojo/common/time.mojom";
9 import "url/mojo/url.mojom"; 9 import "url/mojo/url.mojom";
10 10
(...skipping 17 matching lines...) Expand all
28 // use to query the embedded search interface. |client| is the connection used 28 // use to query the embedded search interface. |client| is the connection used
29 // by the embedded search interface implementation to push browser state 29 // by the embedded search interface implementation to push browser state
30 // updates to the client. 30 // updates to the client.
31 Connect(associated Instant& instant, associated SearchBox client); 31 Connect(associated Instant& instant, associated SearchBox client);
32 }; 32 };
33 33
34 // TODO(tibell): Rename this to EmbeddedSearch. 34 // TODO(tibell): Rename this to EmbeddedSearch.
35 // 35 //
36 // Browser interface to support embedded search. Render frames connect to this 36 // Browser interface to support embedded search. Render frames connect to this
37 // interface to query browser data, such as the most visited pages. 37 // interface to query browser data, such as the most visited pages.
38 // See http://dev.chromium.org/embeddedsearch
38 interface Instant { 39 interface Instant {
39 // Tells InstantExtended whether the embedded search API is supported.
40 // See http://dev.chromium.org/embeddedsearch
41 InstantSupportDetermined(int32 page_seq_no, bool result);
42
43 // Tells InstantExtended to set the omnibox focus state. 40 // Tells InstantExtended to set the omnibox focus state.
44 FocusOmnibox(int32 page_seq_no, OmniboxFocusState state); 41 FocusOmnibox(int32 page_seq_no, OmniboxFocusState state);
45 42
46 // Tells InstantExtended to delete a most visited item. 43 // Tells InstantExtended to delete a most visited item.
47 DeleteMostVisitedItem(int32 page_seq_no, url.mojom.Url url); 44 DeleteMostVisitedItem(int32 page_seq_no, url.mojom.Url url);
48 45
49 // Tells InstantExtended to undo all most visited item deletions. 46 // Tells InstantExtended to undo all most visited item deletions.
50 UndoAllMostVisitedDeletions(int32 page_seq_no); 47 UndoAllMostVisitedDeletions(int32 page_seq_no);
51 48
52 // Tells InstantExtended to undo one most visited item deletion. 49 // Tells InstantExtended to undo one most visited item deletion.
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 [Native] 94 [Native]
98 struct ThemeBackgroundInfo; 95 struct ThemeBackgroundInfo;
99 96
100 // TODO(tibell): Rename this to EmbeddedSearchClient. 97 // TODO(tibell): Rename this to EmbeddedSearchClient.
101 // 98 //
102 // Renderer interface used by the browser to push updates to the client. For 99 // Renderer interface used by the browser to push updates to the client. For
103 // example, the browser will tell the frame if the omnibox got focus. 100 // example, the browser will tell the frame if the omnibox got focus.
104 interface SearchBox { 101 interface SearchBox {
105 SetPageSequenceNumber(int32 page_seq_no); 102 SetPageSequenceNumber(int32 page_seq_no);
106 103
107 DetermineIfPageSupportsInstant();
108
109 FocusChanged(OmniboxFocusState new_focus_state, 104 FocusChanged(OmniboxFocusState new_focus_state,
110 OmniboxFocusChangeReason reason); 105 OmniboxFocusChangeReason reason);
111 106
112 MostVisitedChanged(array<InstantMostVisitedItem> items); 107 MostVisitedChanged(array<InstantMostVisitedItem> items);
113 108
114 SetInputInProgress(bool input_in_progress); 109 SetInputInProgress(bool input_in_progress);
115 110
116 SetSuggestionToPrefetch(InstantSuggestion suggestion); 111 SetSuggestionToPrefetch(InstantSuggestion suggestion);
117 112
118 Submit(mojo.common.mojom.String16 value, 113 Submit(mojo.common.mojom.String16 value,
119 EmbeddedSearchRequestParams params); 114 EmbeddedSearchRequestParams params);
120 115
121 ThemeChanged(ThemeBackgroundInfo value); 116 ThemeChanged(ThemeBackgroundInfo value);
122 117
123 // TODO(treib): Remove the *Result methods and instead add return values to 118 // TODO(treib): Remove the *Result methods and instead add return values to
124 // the correspnding methods in the Instant interface above. 119 // the correspnding methods in the Instant interface above.
125 HistorySyncCheckResult(bool sync_history); 120 HistorySyncCheckResult(bool sync_history);
126 121
127 ChromeIdentityCheckResult(mojo.common.mojom.String16 identity, 122 ChromeIdentityCheckResult(mojo.common.mojom.String16 identity,
128 bool identity_match); 123 bool identity_match);
129 }; 124 };
OLDNEW
« no previous file with comments | « chrome/browser/ui/search/search_tab_helper_unittest.cc ('k') | chrome/common/search/mock_searchbox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698