content/browser/devtools/tethering_handler.cc - Issue 285263003: DevTools: Fixed suspected bug in port forwarding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/tethering_handler.cc

Issue 285263003: DevTools: Fixed suspected bug in port forwarding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed recv and immediate close scenario on Windows Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/tethering_handler.cc

diff --git a/content/browser/devtools/tethering_handler.cc b/content/browser/devtools/tethering_handler.cc

index d3e787d0c01245abdee4243f97b099f600715f6a..9b3b7fa005aa3cdcdaad44977edd1a1ca1fdbf1b 100644

--- a/content/browser/devtools/tethering_handler.cc

+++ b/content/browser/devtools/tethering_handler.cc

@@ -149,7 +149,7 @@ class SocketPump : public net::StreamListenSocket::Delegate {

}

void SelfDestruct() {

- if (wire_buffer_->offset() != wire_buffer_size_) {

+ if (wire_buffer_ && wire_buffer_->offset() != wire_buffer_size_) {

pending_destruction_ = true;

return;

}