Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 285263002: Add additional files required for fips181 compliation (Closed)

Created:
6 years, 7 months ago by Garrett Casto
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add additional files required for fips181 compliation This module still doesn't compile as there are certain dependencies (mainly random number generator) that need to be replaced first, but all necessary third_party code should now included. BUG=165318 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271566

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+779 lines, -0 lines) Patch
A third_party/fips181/convert.h View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/fips181/convert.cc View 1 chunk +407 lines, -0 lines 0 comments Download
M third_party/fips181/fips181.gyp View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/fips181/owntypes.h View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/fips181/randpass.h View 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/fips181/randpass.cc View 1 chunk +163 lines, -0 lines 0 comments Download
A third_party/fips181/smbl.h View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Daniel Berlin
lgtm
6 years, 7 months ago (2014-05-15 20:42:52 UTC) #1
Garrett Casto
The CQ bit was checked by gcasto@chromium.org
6 years, 7 months ago (2014-05-16 19:50:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/285263002/20001
6 years, 7 months ago (2014-05-16 19:51:13 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 19:51:14 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-16 19:51:14 UTC) #5
Garrett Casto
+wfh, need an actual committer to LGTM.
6 years, 7 months ago (2014-05-19 22:04:03 UTC) #6
Will Harris
On 2014/05/19 22:04:03, Garrett Casto wrote: > +wfh, need an actual committer to LGTM. LGTM
6 years, 7 months ago (2014-05-19 22:15:11 UTC) #7
Garrett Casto
The CQ bit was checked by gcasto@chromium.org
6 years, 7 months ago (2014-05-19 22:21:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/285263002/20001
6 years, 7 months ago (2014-05-19 22:21:50 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 02:31:32 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 04:21:08 UTC) #11
Message was sent while issue was closed.
Change committed as 271566

Powered by Google App Engine
This is Rietveld 408576698