net/socket/sequenced_socket_data_unittest.cc - Issue 2852613002: Roll googletest to 1.8.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/sequenced_socket_data_unittest.cc

Issue 2852613002: Roll googletest to 1.8.0. (Closed)

Patch Set: Less elegant fix that should cover all cases. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/sequenced_socket_data_unittest.cc

diff --git a/net/socket/sequenced_socket_data_unittest.cc b/net/socket/sequenced_socket_data_unittest.cc

index b35d1fb9133fce9b12ed8a8b5452472572823ab3..4d54f23322f29ae6249590f878597a8d7dc4d4aa 100644

--- a/net/socket/sequenced_socket_data_unittest.cc

+++ b/net/socket/sequenced_socket_data_unittest.cc

@@ -671,8 +671,8 @@ TEST_F(SequencedSocketDataTest, SingleSyncWriteTooSmall) {

static const char* kExpectedFailures[] = {

"Expected: (data.length()) >= (expected_data.length())",

- "Value of: actual_data",

- "Value of: sock_->Write(buf.get(), len, failing_callback_)"};

+ "To be equal to: actual_data",

+ "To be equal to: sock_->Write(buf.get(), len, failing_callback_)"};

ASSERT_EQ(arraysize(kExpectedFailures),

static_cast<size_t>(gtest_failures.size()));