Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2852603003: Move JsInteropAnalysis.onQueueClosed to AnnotationProcessor.processJsInteropAnnotation (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use [isAnonymous] #

Patch Set 3 : Rebase #

Patch Set 4 : Register anonymous classes correctly + add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -183 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/frontend_strategy.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 2 chunks +1 line, -172 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/native_data.dart View 7 chunks +25 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/native_basic_data.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 1 2 3 3 chunks +149 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/jsinterop/world_test.dart View 1 2 3 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Johnni Winther
3 years, 7 months ago (2017-04-28 14:00:39 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
3 years, 7 months ago (2017-04-28 22:26:05 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 86671fdd56e1163c2e5e1baa77017f43205adb07 (presubmit successful).
3 years, 7 months ago (2017-05-01 12:20:10 UTC) #5
Johnni Winther
PTAL @ the last patch
3 years, 7 months ago (2017-05-02 08:04:55 UTC) #7
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-02 19:59:03 UTC) #8
Johnni Winther
3 years, 7 months ago (2017-05-03 07:33:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
66ead732b1df843efb311b4e04cf0e8d64bcf57f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698