python-adb: List tz sensors in GetDeviceTemperatures()

python-adb: List tz sensors in GetDeviceTemperatures()

They're used for cpu readings in some devices:
https://android.googlesource.com/kernel/msm/+/96394eb1f522c174f85666166d984f68cc9cb17c/Documentation/devicetree/bindings/arm/msm/msm_thermal.txt

BUG=
R=maruel@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=bed58b92f2ede1c487a315f16fc71a09fe95bdbe

[bpastene, 2017-04-28 00:19:44]

Description was changed from

==========
python-adb: List tz sensors in GetDeviceTemperatures()

BUG=
==========

to

==========
python-adb: List tz sensors in GetDeviceTemperatures()

They're used for cpu readings in some devices:
https://android.googlesource.com/kernel/msm/+/96394eb1f522c174f85666166d984f6...

BUG=
==========

[bpastene, 2017-04-28 00:19:44]

bpastene@chromium.org changed reviewers:
+ maruel@chromium.org

[bpastene, 2017-04-28 00:19:52]

https://codereview.chromium.org/2852603002/diff/1/adb/contrib/high.py
File adb/contrib/high.py (left):

https://codereview.chromium.org/2852603002/diff/1/adb/contrib/high.py#oldcode641
adb/contrib/high.py:641: if sensor_type and not
sensor_type.startswith('tsens_tz_sensor'):
Would you happen to remember why they were ignored in the first place? Was it
too spammy?

[M-A Ruel, 2017-04-28 17:15:14]

lgtm with warning

https://codereview.chromium.org/2852603002/diff/1/adb/contrib/high.py
File adb/contrib/high.py (left):

https://codereview.chromium.org/2852603002/diff/1/adb/contrib/high.py#oldcode641
adb/contrib/high.py:641: if sensor_type and not
sensor_type.startswith('tsens_tz_sensor'):
On 2017/04/28 00:19:51, bpastene wrote:
> Would you happen to remember why they were ignored in the first place? Was it
> too spammy?

Yes. It was quite spammy but I don't recall exactly. Another option is to filter
inside bot_config. So I'm fine with this but you should plan updating all the
bot_config to add filtering as needed so they don't self-quarantine.

[bpastene, 2017-04-29 00:24:08]

https://codereview.chromium.org/2852603002/diff/1/adb/contrib/high.py
File adb/contrib/high.py (left):

https://codereview.chromium.org/2852603002/diff/1/adb/contrib/high.py#oldcode641
adb/contrib/high.py:641: if sensor_type and not
sensor_type.startswith('tsens_tz_sensor'):
On 2017/04/28 17:15:13, M-A Ruel wrote:
> On 2017/04/28 00:19:51, bpastene wrote:
> > Would you happen to remember why they were ignored in the first place? Was
it
> > too spammy?
> 
> Yes. It was quite spammy but I don't recall exactly. Another option is to
filter
> inside bot_config. So I'm fine with this but you should plan updating all the
> bot_config to add filtering as needed so they don't self-quarantine.

Will do.

[bpastene, 2017-04-29 00:25:30]

Description was changed from

==========
python-adb: List tz sensors in GetDeviceTemperatures()

They're used for cpu readings in some devices:
https://android.googlesource.com/kernel/msm/+/96394eb1f522c174f85666166d984f6...

BUG=
==========

to

==========
python-adb: List tz sensors in GetDeviceTemperatures()

They're used for cpu readings in some devices:
https://android.googlesource.com/kernel/msm/+/96394eb1f522c174f85666166d984f6...

BUG=
R=maruel@chromium.org

Committed:
https://src.chromium.org/viewvc/chrome?view=rev&revision=bed58b92f2ede1c487a3...
==========

[bpastene, 2017-04-29 00:25:31]

Committed patchset #1 (id:1) manually as
bed58b92f2ede1c487a315f16fc71a09fe95bdbe (presubmit successful).