Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2852573002: Rename InvalidatePaintIfNeeded to drop deprecated IfNeeded suffix. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1360 matching lines...) Expand 10 before | Expand all | Expand 10 after
1371 1371
1372 Lifecycle().AdvanceTo(DocumentLifecycle::kInPaintInvalidation); 1372 Lifecycle().AdvanceTo(DocumentLifecycle::kInPaintInvalidation);
1373 1373
1374 RELEASE_ASSERT(!GetLayoutViewItem().IsNull()); 1374 RELEASE_ASSERT(!GetLayoutViewItem().IsNull());
1375 LayoutViewItem root_for_paint_invalidation = GetLayoutViewItem(); 1375 LayoutViewItem root_for_paint_invalidation = GetLayoutViewItem();
1376 ASSERT(!root_for_paint_invalidation.NeedsLayout()); 1376 ASSERT(!root_for_paint_invalidation.NeedsLayout());
1377 1377
1378 TRACE_EVENT1("blink", "FrameView::invalidateTree", "root", 1378 TRACE_EVENT1("blink", "FrameView::invalidateTree", "root",
1379 root_for_paint_invalidation.DebugName().Ascii()); 1379 root_for_paint_invalidation.DebugName().Ascii());
1380 1380
1381 InvalidatePaintIfNeeded(paint_invalidation_state); 1381 InvalidatePaint(paint_invalidation_state);
1382 root_for_paint_invalidation.InvalidateTreeIfNeeded(paint_invalidation_state); 1382 root_for_paint_invalidation.InvalidateTreeIfNeeded(paint_invalidation_state);
1383 1383
1384 #if DCHECK_IS_ON() 1384 #if DCHECK_IS_ON()
1385 GetLayoutView()->AssertSubtreeClearedPaintInvalidationFlags(); 1385 GetLayoutView()->AssertSubtreeClearedPaintInvalidationFlags();
1386 #endif 1386 #endif
1387 1387
1388 Lifecycle().AdvanceTo(DocumentLifecycle::kPaintInvalidationClean); 1388 Lifecycle().AdvanceTo(DocumentLifecycle::kPaintInvalidationClean);
1389 } 1389 }
1390 1390
1391 void FrameView::InvalidatePaintIfNeeded( 1391 void FrameView::InvalidatePaint(
1392 const PaintInvalidationState& paint_invalidation_state) { 1392 const PaintInvalidationState& paint_invalidation_state) {
1393 RELEASE_ASSERT(!GetLayoutViewItem().IsNull()); 1393 RELEASE_ASSERT(!GetLayoutViewItem().IsNull());
1394 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled()) 1394 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled())
1395 InvalidatePaintOfScrollControlsIfNeeded(paint_invalidation_state); 1395 InvalidatePaintOfScrollControlsIfNeeded(paint_invalidation_state);
1396 } 1396 }
1397 1397
1398 void FrameView::SetNeedsPaintPropertyUpdate() { 1398 void FrameView::SetNeedsPaintPropertyUpdate() {
1399 needs_paint_property_update_ = true; 1399 needs_paint_property_update_ = true;
1400 if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) { 1400 if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
1401 if (auto* layout_view = this->GetLayoutView()) { 1401 if (auto* layout_view = this->GetLayoutView()) {
(...skipping 3986 matching lines...) Expand 10 before | Expand all | Expand 10 after
5388 void FrameView::SetAnimationHost( 5388 void FrameView::SetAnimationHost(
5389 std::unique_ptr<CompositorAnimationHost> host) { 5389 std::unique_ptr<CompositorAnimationHost> host) {
5390 animation_host_ = std::move(host); 5390 animation_host_ = std::move(host);
5391 } 5391 }
5392 5392
5393 LayoutUnit FrameView::CaretWidth() const { 5393 LayoutUnit FrameView::CaretWidth() const {
5394 return LayoutUnit(GetChromeClient()->WindowToViewportScalar(1)); 5394 return LayoutUnit(GetChromeClient()->WindowToViewportScalar(1));
5395 } 5395 }
5396 5396
5397 } // namespace blink 5397 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.h ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698