third_party/WebKit/LayoutTests/media_capabilities/encodingInfo.html - Issue 2852563002: Media Capabilities: stricter checks for the media configuration inputs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media_capabilities/encodingInfo.html

Issue 2852563002: Media Capabilities: stricter checks for the media configuration inputs. (Closed)

Patch Set: review comments and encoding tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/media-capabilities/decodingInfo.html ('k') | third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media_capabilities/encodingInfo.html

diff --git a/third_party/WebKit/LayoutTests/media_capabilities/encodingInfo.html b/third_party/WebKit/LayoutTests/media_capabilities/encodingInfo.html

index cc9ffdb71708accdca0269926cb11a1c69df8985..554e8e2da1c6249a120a23374ea86ce9bc8f183f 100644

--- a/third_party/WebKit/LayoutTests/media_capabilities/encodingInfo.html

+++ b/third_party/WebKit/LayoutTests/media_capabilities/encodingInfo.html

@@ -32,8 +32,10 @@ var createTestForContentType = function(mimeType, isSupported = true) {

assert_equals(isSupported, result.supported, mimeType + 'supported?');

t.done();

})

- .catch(() => {

- assert_unreached('encodingInfo() ' + mimeType);

+ .catch(e => {

+ assert_unreached('encodingInfo() failed with ' + e +

+ ' using mimeType ' + mimeType);

+ t.done();

});

};

@@ -49,12 +51,12 @@ generate_tests(createTestForContentType, [

[ 'video/webm;codecs=avc1', 'video/webm;codecs=avc1' ],

// 'video/webm' supports audio codec specification, see

// http://www.webmproject.org/docs/container/

- [ 'video/webm;codecs=vp8,opus', 'video/webm;codecs=vp8,opus' ],

- [ 'video/WEBM;codecs=VP8,OPUS', 'video/WEBM;codecs=VP8,OPUS' ],

- [ 'video/webm;codecs=vp9,opus', 'video/webm;codecs=vp9,opus' ],

- [ 'video/webm;codecs=vp8,vp9,opus', 'video/webm;codecs=vp8,vp9,opus' ],

- [ 'video/webm;codecs=h264,opus', 'video/webm;codecs=h264,opus' ],

- [ 'video/webm;codecs=h264,vp9,opus', 'video/webm;codecs=h264,vp9,opus' ],

+ [ 'video/webm;codecs="vp8,opus"', 'video/webm;codecs="vp8,opus"' ],

+ [ 'video/WEBM;codecs="VP8,OPUS"', 'video/WEBM;codecs="VP8,OPUS"' ],

+ [ 'video/webm;codecs="vp9,opus"', 'video/webm;codecs="vp9,opus"' ],

+ [ 'video/webm;codecs="vp8,vp9,opus"', 'video/webm;codecs="vp8,vp9,opus"' ],

+ [ 'video/webm;codecs="h264,opus"', 'video/webm;codecs="h264,opus"' ],

+ [ 'video/webm;codecs="h264,vp9,opus"', 'video/webm;codecs="h264,vp9,opus"' ],

// https://matroska.org/technical/specs/notes.html#MIME

[ 'video/x-matroska;codecs=vorbis', 'video/x-matroska;codecs=opus' ],

[ 'audio/webm', 'audio/webm' ],