Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2852463004: Revert "Extend file-system abstraction with a couple methods, remove context." (Closed)

Created:
3 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Extend file-system abstraction with a couple methods, remove context." This reverts commit 99ab24f628b23f248582874a6987883ab76c3195. Tests failed under `--use-sdk`. Fix is simple, but the affected tests seem to be failing because of another CL as well. TBR=brianwilkerson@google.com,paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/6ce9d4e1fb469f0077c0651f80152a0d7594e0b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -161 lines) Patch
M pkg/front_end/lib/file_system.dart View 4 chunks +10 lines, -9 lines 0 comments Download
M pkg/front_end/lib/kernel_generator.dart View 4 chunks +10 lines, -7 lines 0 comments Download
M pkg/front_end/lib/memory_file_system.dart View 5 chunks +8 lines, -27 lines 0 comments Download
M pkg/front_end/lib/physical_file_system.dart View 3 chunks +5 lines, -12 lines 0 comments Download
M pkg/front_end/test/dependency_grapher_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/memory_file_system_test.dart View 9 chunks +14 lines, -38 lines 0 comments Download
M pkg/front_end/test/physical_file_system_test.dart View 2 chunks +0 lines, -66 lines 0 comments Download
M pkg/front_end/test/src/base/processed_options_test.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 6ce9d4e1fb469f0077c0651f80152a0d7594e0b6 (presubmit successful).
3 years, 7 months ago (2017-04-27 21:46:47 UTC) #2
Paul Berry
lgtm
3 years, 7 months ago (2017-04-27 21:48:35 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-04-27 21:51:20 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698