Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10168)

Unified Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2852433003: MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility (Closed)
Patch Set: Rebase + fix settings_main_test.js Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/languages_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/languages_page_browsertest.js b/chrome/test/data/webui/settings/languages_page_browsertest.js
index ae7dfab6a551a5c136e3f01768bb1afa2edb1b84..e9ac0523a99356e2a69ec96d334de3d9364a623c 100644
--- a/chrome/test/data/webui/settings/languages_page_browsertest.js
+++ b/chrome/test/data/webui/settings/languages_page_browsertest.js
@@ -27,7 +27,6 @@ SettingsLanguagesPageBrowserTest.prototype = {
/** @override */
preLoad: function() {
SettingsPageBrowserTest.prototype.preLoad.call(this);
- settingsHidePagesByDefaultForTest = true;
},
};
@@ -83,11 +82,7 @@ TEST_F('SettingsLanguagesPageBrowserTest', 'MAYBE_LanguagesPage', function() {
}
suiteSetup(function() {
- var page = self.basicPage;
- page.set('pageVisibility.languages', true);
- Polymer.dom.flush();
-
- languagesSection = assert(this.getSection(page, 'languages'));
+ languagesSection = assert(this.getSection(self.basicPage, 'languages'));
languagesPage = assert(
languagesSection.querySelector('settings-languages-page'));
languagesCollapse = languagesPage.$.languagesCollapse;

Powered by Google App Engine
This is Rietveld 408576698