Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1839)

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui_types.js

Issue 2852433003: MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility (Closed)
Patch Set: Rebase + fix settings_main_test.js Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_ui/settings_ui.js ('k') | chrome/test/data/webui/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_ui/settings_ui_types.js
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui_types.js b/chrome/browser/resources/settings/settings_ui/settings_ui_types.js
index 4727c62031c046c4140f730f1902d8e4aeb5bf00..4ed8866c16c7cfb358b9843898dba1e1b3eeeaf2 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui_types.js
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui_types.js
@@ -7,9 +7,11 @@
*/
/**
- * Specifies page visibility in guest mode in cr and cros.
+ * Specifies page visibility. Only pages that have conditional visibility
+ * (e.g. in Guest mode) have defined entries.
* @typedef {{
* advancedSettings: (boolean|undefined),
+ * androidApps: (boolean|undefined),
* appearance: (boolean|undefined|AppearancePageVisibility),
* dateTime: (boolean|undefined|DateTimePageVisibility),
* defaultBrowser: (boolean|undefined),
@@ -21,37 +23,37 @@
* reset:(boolean|undefined),
* }}
*/
-var GuestModePageVisibility;
+var PageVisibility;
/**
* @typedef {{
- * bookmarksBar: boolean,
- * homeButton: boolean,
- * pageZoom: boolean,
- * setTheme: boolean,
- * setWallpaper: boolean,
+ * bookmarksBar: (boolean|undefined),
+ * homeButton: (boolean|undefined),
+ * pageZoom: (boolean|undefined),
+ * setTheme: (boolean|undefined),
+ * setWallpaper: (boolean|undefined),
* }}
*/
var AppearancePageVisibility;
/**
* @typedef {{
- * timeZoneSelector: boolean,
+ * timeZoneSelector: (boolean|undefined),
* }}
*/
var DateTimePageVisibility;
/**
* @typedef {{
- * googleDrive: boolean
+ * googleDrive: (boolean|undefined)
* }}
*/
var DownloadsPageVisibility;
/**
* @typedef {{
- * networkPrediction: boolean,
- * searchPrediction: boolean,
+ * networkPrediction: (boolean|undefined),
+ * searchPrediction: (boolean|undefined),
* }}
*/
var PrivacyPageVisibility;
« no previous file with comments | « chrome/browser/resources/settings/settings_ui/settings_ui.js ('k') | chrome/test/data/webui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698