Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2852433003: MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility (Closed)
Patch Set: Rebase + fix settings_main_test.js Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @typedef {{about: boolean, settings: boolean}} 6 * @typedef {{about: boolean, settings: boolean}}
7 */ 7 */
8 var MainPageVisibility; 8 var MainPageVisibility;
9 9
10 /** 10 /**
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 value: false, 64 value: false,
65 }, 65 },
66 66
67 toolbarSpinnerActive: { 67 toolbarSpinnerActive: {
68 type: Boolean, 68 type: Boolean,
69 value: false, 69 value: false,
70 notify: true, 70 notify: true,
71 }, 71 },
72 72
73 /** 73 /**
74 * Dictionary defining page visibility. 74 * Dictionary defining page visibility. Controlled by settings-ui.
75 * @type {!GuestModePageVisibility} 75 * @type {!PageVisibility|undefined}
76 */ 76 */
77 pageVisibility: { 77 pageVisibility: Object,
78 type: Object,
79 value: function() {
80 return {};
81 },
82 },
83
84 showAndroidApps: Boolean,
85 }, 78 },
86 79
87 /** @override */ 80 /** @override */
88 attached: function() { 81 attached: function() {
89 this.listen(this, 'freeze-scroll', 'onFreezeScroll_'); 82 this.listen(this, 'freeze-scroll', 'onFreezeScroll_');
90 this.listen(this, 'lazy-loaded', 'onLazyLoaded_'); 83 this.listen(this, 'lazy-loaded', 'onLazyLoaded_');
91 }, 84 },
92 85
93 /** @private */ 86 /** @private */
94 onLazyLoaded_: function() { 87 onLazyLoaded_: function() {
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 text: this.showNoResultsFound_ ? 276 text: this.showNoResultsFound_ ?
284 loadTimeData.getString('searchNoResults') : 277 loadTimeData.getString('searchNoResults') :
285 loadTimeData.getStringF('searchResults', query) 278 loadTimeData.getStringF('searchResults', query)
286 }); 279 });
287 } 280 }
288 }.bind(this)); 281 }.bind(this));
289 }.bind(this), 0); 282 }.bind(this), 0);
290 }.bind(this)); 283 }.bind(this));
291 }, 284 },
292 }); 285 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698