third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h - Issue 2852423002: Expose passwords to JavaScript in Credential Manager API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

Issue 2852423002: Expose passwords to JavaScript in Credential Manager API (Closed)

Patch Set: WPT Tests and Readonly Password Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/external/wpt/credential-management/idl.https.html ('K') | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

diff --git a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

index b84fa50a1025b778d358eeaf8acaa2f6f90ea627..6fe40db19d7cfcbbc213d106c493c58e6c4189e4 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

+++ b/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h

@@ -45,9 +45,10 @@ class MODULES_EXPORT PasswordCredential final : public CredentialUserData {

out = additional_data_;

}

+ const String& password() const;

// Internal methods

PassRefPtr<EncodedFormData> EncodeFormData(String& content_type) const;

- const String& Password() const;

DECLARE_VIRTUAL_TRACE();

private:

@@ -59,6 +60,7 @@ class MODULES_EXPORT PasswordCredential final : public CredentialUserData {

String id_name_;

String password_name_;

+ String password_;

CredentialPostBodyType additional_data_;

};