Expose passwords to JavaScript in Credential Manager API

third_party/WebKit/Source/core/frame/Deprecation.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/Deprecation.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/frame/FrameConsole.h"
 #include "core/frame/LocalFrame.h"
@@ skipping 396 matching lines @@
           milestoneString(M60));
 
     case UseCounter::kV8RTCPeerConnection_GetStreamById_Method:
       return willBeRemoved("RTCPeerConnection.getStreamById()", M62,
                            "5751819573657600");
 
     case UseCounter::kV8SVGPathElement_GetPathSegAtLength_Method:
       return willBeRemoved("SVGPathElement.getPathSegAtLength", M62,
                            "5638783282184192");
 
+    // TODO(jdoerrie): Create separate Chrome Platform Status entry.
+    case UseCounter::kCredentialManagerIdName:
+      return willBeRemoved("PasswordCredential.idName", M62,
+                           "5026422640869376");
+
+    // TODO(jdoerrie): Create separate Chrome Platform Status entry.
+    case UseCounter::kCredentialManagerPasswordName:
+      return willBeRemoved("PasswordCredential.passwordName", M62,
+                           "5026422640869376");
+
+    // TODO(jdoerrie): Create separate Chrome Platform Status entry.
+    case UseCounter::kCredentialManagerAdditionalData:
+      return willBeRemoved("PasswordCredential.additionalData", M62,
+                           "5026422640869376");
+
+    // TODO(jdoerrie): Create separate Chrome Platform Status entry.
+    case UseCounter::kCredentialManagerCustomFetch:
+      return willBeRemoved("fetch.RequestInit.RequestCredentials.password", M62,

[Mike West, 2017/05/04 11:13:33]

We'll want a friendlier deprecation message than this produces, pointing
developers to the new `.password` attribute. It's also going to require some
rework for developers who have invested in the `fetch()` workflow, so it's
probably worth talking to folks about putting together a short migration article
to which we can point developers, showing them a drop-in replacement for the
`fetch()` flow. That is, instead of:

```
c.idName = "id";
c.passwordName = "password";
c.additionalData = formData;
fetch(url, { credentials: c, method: "POST" });
```

they'd want something like:

```
formData.set("id", c.id);
formData.set("password", c.password);
fetch(url, { credentials: "include", body: formData, method: "POST" });
```

[jdoerrie, 2017/05/04 14:24:10]

Acknowledged.

+                           "5026422640869376");
+
     // Features that aren't deprecated don't have a deprecation message.
     default:
       return String();
   }
 }
 
 }  // namespace blink