Expose passwords to JavaScript in Credential Manager API

third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/credentialmanager/PasswordCredential.h"
 
 #include <memory>
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/URLSearchParams.h"
 #include "core/frame/FrameView.h"
 #include "core/html/FormData.h"
 #include "core/html/HTMLFormElement.h"
 #include "core/html/forms/FormController.h"
 #include "core/testing/DummyPageHolder.h"
+#include "platform/RuntimeEnabledFeatures.h"
 #include "platform/wtf/text/StringBuilder.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blink {
 
 class PasswordCredentialTest : public ::testing::Test {
  protected:
   void SetUp() override {
     dummy_page_holder_ = DummyPageHolder::Create();
     document_ = &dummy_page_holder_->GetDocument();
@@ skipping 33 matching lines @@
                    "<input type='text' name='theExtraField' value='extra'>"
                    "<input type='text' name='theName' value='friendly name' "
                    "autocomplete='name'>");
   PasswordCredential* credential =
       PasswordCredential::Create(form, ASSERT_NO_EXCEPTION);
   ASSERT_NE(nullptr, credential);
   EXPECT_EQ("theId", credential->idName());
   EXPECT_EQ("thePassword", credential->passwordName());
 
   EXPECT_EQ("musterman", credential->id());
-  EXPECT_EQ("sekrit", credential->Password());
+  if (RuntimeEnabledFeatures::passwordCredentialPasswordEnabled())
+    EXPECT_EQ("sekrit", credential->password());
   EXPECT_EQ(KURL(kParsedURLString, "https://example.com/photo"),
             credential->iconURL());
   EXPECT_EQ("friendly name", credential->name());
   EXPECT_EQ("password", credential->type());
 
   FormDataOrURLSearchParams additional_data;
   credential->additionalData(additional_data);
   ASSERT_TRUE(additional_data.isFormData());
   EXPECT_TRUE(additional_data.getAsFormData()->has("theId"));
   EXPECT_TRUE(additional_data.getAsFormData()->has("thePassword"));
@@ skipping 14 matching lines @@
                    "<input type='text' name='theExtraField' value='extra'>"
                    "<input type='text' name='theName' value='friendly name' "
                    "autocomplete='name'>");
   PasswordCredential* credential =
       PasswordCredential::Create(form, ASSERT_NO_EXCEPTION);
   ASSERT_NE(nullptr, credential);
   EXPECT_EQ("theId", credential->idName());
   EXPECT_EQ("thePassword", credential->passwordName());
 
   EXPECT_EQ("musterman", credential->id());
-  EXPECT_EQ("sekrit", credential->Password());
+  if (RuntimeEnabledFeatures::passwordCredentialPasswordEnabled())

[Mike West, 2017/05/16 09:30:45]

I'd drop these `if`s, as per the discussion above.

[jdoerrie, 2017/05/17 15:39:22]

Done.

+    EXPECT_EQ("sekrit", credential->password());
   EXPECT_EQ(KURL(kParsedURLString, "https://example.com/photo"),
             credential->iconURL());
   EXPECT_EQ("friendly name", credential->name());
   EXPECT_EQ("password", credential->type());
 
   FormDataOrURLSearchParams additional_data;
   credential->additionalData(additional_data);
   ASSERT_TRUE(additional_data.isURLSearchParams());
   EXPECT_TRUE(additional_data.getAsURLSearchParams()->has("theId"));
   EXPECT_TRUE(additional_data.getAsURLSearchParams()->has("thePassword"));
@@ skipping 34 matching lines @@
   DummyExceptionStateForTesting exception_state;
   PasswordCredential* credential =
       PasswordCredential::Create(form, exception_state);
   EXPECT_EQ(nullptr, credential);
   EXPECT_TRUE(exception_state.HadException());
   EXPECT_EQ(kV8TypeError, exception_state.Code());
   EXPECT_EQ("'id' must not be empty.", exception_state.Message());
 }
 
 }  // namespace blink