Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.js

Issue 2852413003: MD Settings: omnibox extensions list to use focus-row-behavior. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-search-engines-page' is the settings page 6 * @fileoverview 'settings-search-engines-page' is the settings page
7 * containing search engines settings. 7 * containing search engines settings.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-search-engines-page', 10 is: 'settings-search-engines-page',
(...skipping 28 matching lines...) Expand all
39 value: settings.Route.SEARCH_ENGINES, 39 value: settings.Route.SEARCH_ENGINES,
40 }, 40 },
41 41
42 /** @private {boolean} */ 42 /** @private {boolean} */
43 showAddSearchEngineDialog_: Boolean, 43 showAddSearchEngineDialog_: Boolean,
44 44
45 /** @private {boolean} */ 45 /** @private {boolean} */
46 showExtensionsList_: { 46 showExtensionsList_: {
47 type: Boolean, 47 type: Boolean,
48 computed: 'computeShowExtensionsList_(extensions)', 48 computed: 'computeShowExtensionsList_(extensions)',
49 } 49 },
50
51 /** @private {Object}*/
dpapad 2017/05/04 16:35:32 What is the type of this member variable? Can we d
scottchen 2017/05/04 21:57:38 Done.
52 OmniboxExtensionlastFocused_: Object,
dpapad 2017/05/04 16:35:32 s/Omnibox/omnibox
scottchen 2017/05/04 21:57:38 Done.
50 }, 53 },
51 54
52 // Since the iron-list for extensions is enclosed in a dom-if, observe both 55 // Since the iron-list for extensions is enclosed in a dom-if, observe both
53 // |extensions| and |showExtensionsList_|. 56 // |extensions| and |showExtensionsList_|.
54 observers: ['extensionsChanged_(extensions, showExtensionsList_)'], 57 observers: ['extensionsChanged_(extensions, showExtensionsList_)'],
55 58
56 /** @override */ 59 /** @override */
57 ready: function() { 60 ready: function() {
58 settings.SearchEnginesBrowserProxyImpl.getInstance(). 61 settings.SearchEnginesBrowserProxyImpl.getInstance().
59 getSearchEnginesList().then(this.enginesChanged_.bind(this)); 62 getSearchEnginesList().then(this.enginesChanged_.bind(this));
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 this.$.addSearchEngine.focus(); 102 this.$.addSearchEngine.focus();
100 }.bind(this)); 103 }.bind(this));
101 }.bind(this)); 104 }.bind(this));
102 }, 105 },
103 106
104 /** @private */ 107 /** @private */
105 computeShowExtensionsList_: function() { 108 computeShowExtensionsList_: function() {
106 return this.extensions.length > 0; 109 return this.extensions.length > 0;
107 }, 110 },
108 }); 111 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698