Make virtual keyboard work on supervised user creation

ash/test/ash_test_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/test/ash_test_base.h"
 
 #include <string>
 #include <vector>
 
 #include "ash/display/extended_mouse_warp_controller.h"
@@ skipping 30 matching lines @@
 #include "ui/aura/window.h"
 #include "ui/aura/window_delegate.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/base/ime/input_method_initializer.h"
 #include "ui/display/display.h"
 #include "ui/display/screen.h"
 #include "ui/display/test/display_manager_test_api.h"
 #include "ui/display/types/display_constants.h"
 #include "ui/events/gesture_detection/gesture_configuration.h"
 #include "ui/gfx/geometry/point.h"
+#include "ui/keyboard/keyboard_controller.h"
 #include "ui/wm/core/coordinate_conversion.h"
 
 #if defined(USE_X11)
 #include "ui/gfx/x/x11_connection.h"  // nogncheck
 #endif
 
 namespace ash {
 namespace test {
 namespace {
 
@@ skipping 101 matching lines @@
 
 void AshTestBase::SetUp() {
   setup_called_ = true;
 
   // Clears the saved state so that test doesn't use on the wrong
   // default state.
   shell::ToplevelWindow::ClearSavedStateForTest();
 
   ash_test_helper_->SetUp(start_session_);
 
+  // The following function should be invoked from
+  // ChromeBrowserMainExtraPartsAsh::PostProfileInit
+  // on real Chrome OS. Without this,
+  // LockActionHandlerLayoutManagerTest.KeyboardBounds fails on
+  // ShowKeyboard(true).
+  ash::Shell::GetPrimaryRootWindowController()->ActivateKeyboard(
+      keyboard::KeyboardController::GetInstance());

[xiyuan, 2017/06/07 15:08:13]

If only that test fails without this, should this be part of that test's SetUp
instead?

ash_test_helper_->SetUp() call above should set ACTIVE session state and
CreateKeyboard should be exercised. Not sure why we need to do this now.

[oka, 2017/06/07 15:45:19]

ash_test_helper_->SetUp() initializes the keyboard controller instance from
RootWindowController::Init(), before the state becomes active. The same thing
happens on real OS on start up.
However, on real workflow, RootWindowController::ActivateKeyboard is called
after that from ChromeBrowserMainExtraPartsAsh::PostProfileInit and the
controller  becomes a sane state.

[xiyuan, 2017/06/07 16:18:13]

But Shell::CreateKeyboard calls ActivateKeyboard too. So if session state
changes to ACTIVE, Shell::CreateKeyboard should do that already. I don't
understand why we need to do this explicitlyl again here.

+
   Shell::GetPrimaryRootWindow()->Show();
   Shell::GetPrimaryRootWindow()->GetHost()->Show();
   // Move the mouse cursor to far away so that native events doesn't
   // interfere test expectations.
   Shell::GetPrimaryRootWindow()->MoveCursorTo(gfx::Point(-1000, -1000));
   // TODO: mus/mash needs to support CursorManager. http://crbug.com/637853.
   if (Shell::GetAshConfig() == Config::CLASSIC)
     Shell::Get()->cursor_manager()->EnableMouseEvents();
 
   UnblockCompositors();
@@ skipping 321 matching lines @@
   return display::Screen::GetScreen()->GetDisplayNearestWindow(
       Shell::GetPrimaryRootWindow());
 }
 
 display::Display AshTestBase::GetSecondaryDisplay() {
   return ash_test_helper_->GetSecondaryDisplay();
 }
 
 }  // namespace test
 }  // namespace ash