content/public/test/render_view_test.cc - Issue 2852373004: Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/render_view_test.cc

Issue 2852373004: Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8. (Closed)

Patch Set: fix-hang Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/test/render_view_test.cc

diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc

index e04ab92c730ea71ff925a9415a3d9207f1aed6e1..1afbb54c36991dd73b3a0f809e619d36c96e67f7 100644

--- a/content/public/test/render_view_test.cc

+++ b/content/public/test/render_view_test.cc

@@ -157,9 +157,7 @@ RenderViewTest::~RenderViewTest() {

}

void RenderViewTest::ProcessPendingMessages() {

- msg_loop_.task_runner()->PostTask(FROM_HERE,

- base::MessageLoop::QuitWhenIdleClosure());

- base::RunLoop().Run();

+ base::RunLoop().RunUntilIdle();

}

WebLocalFrame* RenderViewTest::GetMainFrame() {