Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/test/base/v8_unit_test.cc

Issue 2852373004: Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8. (Closed)
Patch Set: fix-hang Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/v8_unit_test.cc
diff --git a/chrome/test/base/v8_unit_test.cc b/chrome/test/base/v8_unit_test.cc
index 55aefc43e14c6794186703bf676ba862d6f4ed05..c35563719f15b71cd10050edbae7b5c0e7a2424a 100644
--- a/chrome/test/base/v8_unit_test.cc
+++ b/chrome/test/base/v8_unit_test.cc
@@ -7,7 +7,6 @@
#include "base/files/file_util.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
-#include "base/message_loop/message_loop.h"
#include "base/path_service.h"
#include "base/strings/string_piece.h"
#include "base/strings/stringprintf.h"
@@ -202,8 +201,6 @@ void V8UnitTest::SetUp() {
console->NewInstance(context).ToLocalChecked())
.ToChecked();
}
-
- loop_ = base::MakeUnique<base::MessageLoop>();
gab 2017/05/03 17:38:36 That's peculiar. Should check with owners if there
}
void V8UnitTest::SetGlobalStringVar(const std::string& var_name,

Powered by Google App Engine
This is Rietveld 408576698