Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Side by Side Diff: content/test/blink_test_environment.cc

Issue 2852373004: Use ScopedTaskEnvironment instead of MessageLoop in tests that use v8. (Closed)
Patch Set: Reset-RenderViewTest Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/base/v8_unit_test.cc ('k') | content/test/ppapi_unittest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/test/blink_test_environment.h" 5 #include "content/test/blink_test_environment.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/message_loop/message_loop.h"
11 #include "base/run_loop.h" 10 #include "base/run_loop.h"
12 #include "base/strings/string_tokenizer.h" 11 #include "base/strings/string_tokenizer.h"
12 #include "base/test/scoped_task_environment.h"
13 #include "base/test/test_discardable_memory_allocator.h" 13 #include "base/test/test_discardable_memory_allocator.h"
14 #include "base/third_party/dynamic_annotations/dynamic_annotations.h" 14 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
15 #include "build/build_config.h" 15 #include "build/build_config.h"
16 #include "content/public/common/content_switches.h" 16 #include "content/public/common/content_switches.h"
17 #include "content/public/common/user_agent.h" 17 #include "content/public/common/user_agent.h"
18 #include "content/public/test/test_content_client_initializer.h" 18 #include "content/public/test/test_content_client_initializer.h"
19 #include "content/test/test_blink_web_unit_test_support.h" 19 #include "content/test/test_blink_web_unit_test_support.h"
20 #include "third_party/WebKit/public/platform/WebCache.h" 20 #include "third_party/WebKit/public/platform/WebCache.h"
21 #include "third_party/WebKit/public/web/WebKit.h" 21 #include "third_party/WebKit/public/web/WebKit.h"
22 #include "third_party/WebKit/public/web/WebRuntimeFeatures.h" 22 #include "third_party/WebKit/public/web/WebRuntimeFeatures.h"
23 #include "url/url_util.h" 23 #include "url/url_util.h"
24 24
25 #if defined(OS_WIN) 25 #if defined(OS_WIN)
26 #include "ui/display/win/dpi.h" 26 #include "ui/display/win/dpi.h"
27 #endif 27 #endif
28 28
29 #if defined(OS_MACOSX) 29 #if defined(OS_MACOSX)
30 #include "base/test/mock_chrome_application_mac.h" 30 #include "base/test/mock_chrome_application_mac.h"
31 #endif 31 #endif
32 32
33 namespace content { 33 namespace content {
34 34
35 namespace { 35 namespace {
36 36
37 class TestEnvironment { 37 class TestEnvironment {
38 public: 38 public:
39 #if defined(OS_ANDROID) 39 TestEnvironment()
40 // Android UI message loop goes through Java, so don't use it in tests. 40 #if !defined(OS_ANDROID)
41 typedef base::MessageLoop MessageLoopType; 41 // On Android, Java pumps UI messages.
42 #else 42 : scoped_task_environment_(
43 typedef base::MessageLoopForUI MessageLoopType; 43 base::test::ScopedTaskEnvironment::MainThreadType::UI)
44 #endif 44 #endif
45 45 {
46 TestEnvironment() {
47 main_message_loop_.reset(new MessageLoopType);
48
49 // TestBlinkWebUnitTestSupport must be instantiated after MessageLoopType.
50 blink_test_support_.reset(new TestBlinkWebUnitTestSupport);
51 content_initializer_.reset(new content::TestContentClientInitializer());
52
53 base::DiscardableMemoryAllocator::SetInstance( 46 base::DiscardableMemoryAllocator::SetInstance(
54 &discardable_memory_allocator_); 47 &discardable_memory_allocator_);
55 } 48 }
56 49
57 ~TestEnvironment() { 50 ~TestEnvironment() {
58 } 51 }
59 52
60 TestBlinkWebUnitTestSupport* blink_platform_impl() const { 53 private:
61 return blink_test_support_.get(); 54 base::test::ScopedTaskEnvironment scoped_task_environment_;
62 }
63 55
64 private: 56 // Must be instantiated after ScopedTaskEnvironment.
65 std::unique_ptr<MessageLoopType> main_message_loop_; 57 TestBlinkWebUnitTestSupport blink_test_support_;
66 std::unique_ptr<TestBlinkWebUnitTestSupport> blink_test_support_; 58
67 std::unique_ptr<TestContentClientInitializer> content_initializer_; 59 TestContentClientInitializer content_initializer_;
68 base::TestDiscardableMemoryAllocator discardable_memory_allocator_; 60 base::TestDiscardableMemoryAllocator discardable_memory_allocator_;
69 }; 61 };
70 62
71 TestEnvironment* test_environment; 63 TestEnvironment* test_environment;
72 64
73 } // namespace 65 } // namespace
74 66
75 void SetUpBlinkTestEnvironment() { 67 void SetUpBlinkTestEnvironment() {
76 blink::WebRuntimeFeatures::EnableExperimentalFeatures(true); 68 blink::WebRuntimeFeatures::EnableExperimentalFeatures(true);
77 blink::WebRuntimeFeatures::EnableTestOnlyFeatures(true); 69 blink::WebRuntimeFeatures::EnableTestOnlyFeatures(true);
(...skipping 18 matching lines...) Expand all
96 // http://code.google.com/p/chromium/issues/detail?id=9500 88 // http://code.google.com/p/chromium/issues/detail?id=9500
97 base::RunLoop().RunUntilIdle(); 89 base::RunLoop().RunUntilIdle();
98 90
99 if (RunningOnValgrind()) 91 if (RunningOnValgrind())
100 blink::WebCache::Clear(); 92 blink::WebCache::Clear();
101 delete test_environment; 93 delete test_environment;
102 test_environment = NULL; 94 test_environment = NULL;
103 } 95 }
104 96
105 } // namespace content 97 } // namespace content
OLDNEW
« no previous file with comments | « chrome/test/base/v8_unit_test.cc ('k') | content/test/ppapi_unittest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698