Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2852373002: Add import/export declaration AST node boilerplate to kernel. (Closed)

Created:
3 years, 7 months ago by asgerf
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add import/export declaration AST node boilerplate to kernel. Previously only deferred imports were represented. They have been merged with the general form. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/876db33bf4f4000c605f27f1bea726c632d379b2

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Update handling of strings to use indices #

Patch Set 4 : Merge and adapt C++ code to upstream changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+362 lines, -73 lines) Patch
M pkg/analyzer/lib/src/kernel/loader.dart View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 2 3 4 chunks +7 lines, -7 lines 0 comments Download
M pkg/kernel/binary.md View 1 2 3 4 chunks +19 lines, -11 lines 0 comments Download
M pkg/kernel/lib/ast.dart View 1 2 3 7 chunks +100 lines, -15 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 1 2 3 5 chunks +28 lines, -9 lines 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 1 2 3 6 chunks +43 lines, -20 lines 0 comments Download
M pkg/kernel/lib/text/ast_to_text.dart View 1 2 3 3 chunks +15 lines, -6 lines 0 comments Download
M pkg/kernel/lib/visitor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/kernel.h View 1 2 3 7 chunks +87 lines, -0 lines 0 comments Download
M runtime/vm/kernel.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/kernel_binary.cc View 1 2 3 4 chunks +41 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
3 years, 7 months ago (2017-05-02 14:26:39 UTC) #2
Kevin Millikin (Google)
LGTM.
3 years, 7 months ago (2017-05-10 10:24:36 UTC) #3
asgerf
3 years, 7 months ago (2017-05-18 12:38:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
876db33bf4f4000c605f27f1bea726c632d379b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698