Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: components/payments/content/payment_details_validation.cc

Issue 2852363002: [payment] display mixed currency in item list and shipping optiopns. When there is more than one cu… (Closed)
Patch Set: more minor changes requested by code reviewing Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/payments/content/payment_details_validation.cc
diff --git a/components/payments/content/payment_details_validation.cc b/components/payments/content/payment_details_validation.cc
index 1edd6fb1fa56e2f7138a384bf4264a3fc60aa213..8fb94b632891d7d5ae8bb5b63705e6fbf3eef95f 100644
--- a/components/payments/content/payment_details_validation.cc
+++ b/components/payments/content/payment_details_validation.cc
@@ -35,10 +35,12 @@ bool validateShippingOptionOrPaymentItem(
return false;
}
+#if !defined(OS_ANDROID)
please use gerrit instead 2017/05/05 19:13:55 Desktop should behave the same as Android. Please
wuandy1 2017/05/05 19:50:11 Done.
if (total && item->amount->currency != total->amount->currency) {
*error_message = "Currencies must all be equal";
return false;
}
+#endif
if (item->amount->currency_system.empty()) {
*error_message = "Currency system can't be empty";
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698