components/security_interstitials/core/browser/resources/interstitial_v2.js - Issue 2852333003: Rename SafeBrowsingErrorUI to SafeBrowsingLoudErrorUI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/core/browser/resources/interstitial_v2.js

Issue 2852333003: Rename SafeBrowsingErrorUI to SafeBrowsingLoudErrorUI (Closed)

Patch Set: Move SafeBrowsingErrorUI to SafeBrowsingLoudErrorUI Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing/base_blocking_page.h ('K') | « components/security_interstitials/core/base_safe_browsing_error_ui.h ('k') | components/security_interstitials/core/controller_client.h » ('j') | components/security_interstitials/core/controller_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/core/browser/resources/interstitial_v2.js

diff --git a/components/security_interstitials/core/browser/resources/interstitial_v2.js b/components/security_interstitials/core/browser/resources/interstitial_v2.js

index 4fa48eac865d91d45a46eb37c794bca79e03efa5..7fe6ac69adb52d826b13a3e4fc214512044f135c 100644

--- a/components/security_interstitials/core/browser/resources/interstitial_v2.js

+++ b/components/security_interstitials/core/browser/resources/interstitial_v2.js

@@ -102,7 +102,8 @@ function setupEvents() {

var ssl = interstitialType == 'SSL';

var captivePortal = interstitialType == 'CAPTIVE_PORTAL';

var badClock = ssl && loadTimeData.getBoolean('bad_clock');

- var hidePrimaryButton = badClock && loadTimeData.getBoolean(

+ var webView = loadTimeData.getBoolean('webview');

+ var hidePrimaryButton = (badClock || webView) && loadTimeData.getBoolean(

'hide_primary_button');

felt 2017/05/03 18:17:01 I don't think we need this webView variable. We sh

if (ssl) {