chrome/chrome_browser.gypi - Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 285233012: Abstract history dependencies on bookmarks through HistoryClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 9dd45a7736f9b730df46f46304f5d252a46fbbef..d254bf08b616f18a7fcb0575adccd17dcd9c0c68 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -39,6 +39,7 @@

'../components/components.gyp:feedback_component',

'../components/components.gyp:gcm_driver',

'../components/components.gyp:google_core_browser',

+ '../components/components.gyp:history_core_browser',

'../components/components.gyp:infobars_core',

'../components/components.gyp:invalidation',

'../components/components.gyp:metrics',

@@ -769,6 +770,8 @@

'browser/history/android/visit_sql_handler.h',

'browser/history/archived_database.cc',

'browser/history/archived_database.h',

+ 'browser/history/chrome_history_client.cc',

+ 'browser/history/chrome_history_client.h',

'browser/history/delete_directive_handler.cc',

'browser/history/delete_directive_handler.h',

'browser/history/download_database.cc',

« no previous file with comments | « chrome/browser/sync/profile_sync_service_typed_url_unittest.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | components/history.gypi » ('J')